[tur-nr]

Problem

compactRange() treats any object argument as options, and a Buffer is an object. So compactRange(start, end, opts) with Buffer keys uses end as the options, compacts from start to the end of the keyspace and drops the real options. A lone Buffer start is treated as options too, so the whole keyspace gets compacted.

Proposal

Only treat an argument as options when it isn't an ArrayBuffer view.

Tests

• With three L0 files, compactRange(Buffer) and compactRange(Buffer, Buffer) only compact the files in range, checked with rocksdb.num-files-at-level0.
• bottommostLevelCompaction: FORCE passed with Buffer keys is honoured, checked by a stale version in the bottommost level being dropped (rocksdb.estimate-num-keys).

[kasperisager]

I wonder if LSan caught a genuine leak or if it's a false positive 🤔

[tur-nr]

@kasperisager should I re-run or is there something I can do locally to test against flakes with leak scanner?

[tur-nr]

Seems to a leak on your asan PR too, so likely not this change.

[kasperisager]

It's a finalizer leak, I'm fixing it.

[kasperisager]

holepunchto/libjs#71