Repository navigation
Retire the IPC poll before closing its loop - #134
Merged
Merged
Conversation
kasperisager
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two poll tests close their loop while the poll is still armed. The worklet's exit makes the host end readable, the poll's callback posts to that loop, and the callback then runs against a closed loop.
Pipes hide it, because their EOF arrives asynchronously at thread teardown, so the wake lands after the test is done. It is wrong on any transport though, and it segfaults on linux-x64 once EOF is synchronous - which is how I found it, in #94.
Split out of #94 so it can land on its own. Verified here: 5/5 in the IPC tests and 200 stress runs clean on darwin-arm64.