Repository navigation
Keep lunte out of the build tree - #131
Merged
Merged
Conversation
lunte does not read .gitignore, so anyone with a build tree lints the fetched dependencies: libuv v1.52.1 alone reports 14 errors from its vendored sample code, which fails npm run lint locally while CI passes with no build tree.
kasperisager
approved these changes
Sep 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
luntedoes not read.gitignore, sonpm run lintwalks into the build tree and lints whatever the build fetched. libuv v1.52.1 alone reports 14 errors from its vendored sample code:CI never sees this because the
Lintjob runs onnode-basewith no build tree, so it only bites locally - and blocks a pre-push hook that runs the same command.build/andprebuilds/are the generated and downloaded directories, per the convention;prebuilds/holds only aMakefiletoday, so nothing lintable is being excluded.