Repository navigation
Publish without a restored package cache - #113
Closed
bavulapati wants to merge 1 commit into
Closed
bavulapati wants to merge 1 commit into
bavulapati wants to merge 1 commit into
Conversation
bavulapati
force-pushed
the
publish-no-cache
branch
from
August 29, 2026 11:57
5d8cff3 to
c3c1ce0
Compare
kasperisager
requested changes
Aug 29, 2026
Contributor
Author
|
Closing in favour of holepunchto/actions#107, which turns the cache off in the shared 'setup-node' action instead. Two things changed since this was opened. #114 moved these four steps onto 'holepunchto/actions/setup-node', so the raw 'actions/setup-node' calls this patches are gone and it no longer applies. And #114 on its own only hid the finding - zizmor cannot see inside a composite action, so Security went green while the release build still restored the cache. #107 fixes the behaviour at the layer that owns it, defaulted off, so this workflow needs no opt-out of its own and no other publish workflow inherits the gap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #112, which closed itself when its base branch was deleted on merging #111. Same commit, rebased onto main - I should have retargeted it before merging, not after.
setup-nodev6 turns on package-manager caching by default, so the release build restored a cache that jobs on other refs can populate. In a workflow that publishes, that is a path from a poisoned cache into what we ship, which is why zizmor reports it here and not inintegrate.yml.package-manager-cache: falseon the foursetup-nodesteps inpublish.ymlis the documented way off. It costs a clean install per job, on a workflow that runs once per release.Last of the findings behind #109: with this, zizmor reports nothing on the version CI pins.