Correct number of pinned columns in compound balance reports in FODS output - #2729
Merged
simonmichael merged 2 commits intoSep 12, 2026
Merged
simonmichael merged 2 commits into
simonmichael merged 2 commits into
Conversation
Member
|
The imp: and fix: prefixes suggest user-visible changes - what might those be ? |
Contributor
Author
|
On Sat, 12 Sep 2026, Simon Michael wrote:
[10144?s=20&v=4] simonmichael left a comment (hledgerorg/hledger#2729)
The imp: and fix: prefixes suggest user-visible changes - what might those be ?
Before the fix, the wrong number of columns was pinned in FODS output.
For "imp:" I guess I mixed up "improvement" with "implementation".
|
Member
|
Cool. If you wouldn't mind, reword the fix: message so it'll generate a useful item in the release notes when the time comes. |
Member
|
(It may have been clear already to people with the right context.. maybe something like "imp: fods: pin the correct columns in FODS output" ) |
order is now more idiomatic
…balance and compound balance reports. Commands.Balance.multiBalanceReportNumHeaderColumns: determine correct number of header columns
thielema
force-pushed
the
compound-balance-number-header-columns
branch
from
September 12, 2026 19:53
717c319 to
19fa01b
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a small bugfix