Commands.Balance: pass allCommodities in AmountFormat

[thielema]

I try to address the suggestion by Opus AI:
#2691 (comment)

The suggestion was to avoid the allCommodities parameters by using the displayCommodityOrder field of the AmountFormat parameters.

Currently the exported reporting functions call lower-level functions with an AmountFormat parameter, that is usually one of noCostFmt, oneLineNoCostFmt, machineFmt or modifications of those. On the way down some fields like displayCommodity and displayCommodityOrder are replaced. I do not like this design very much, because it is not obvious that some fields of AmountFormat you pass to a public reporting function are just overwritten, and thus ignored. I'd prefer if a user only passes values that have an effect.

However, I also see that AmountFormat is huge and an approach without overwriting fields would require many more function parameters.

This draft pull request leaves the AmountFormat mutation approach and sets displayCommodityOrder at a higher level in case of layout=barewide. In principle this works, but e.g. in multiBalanceReportAsSpreadsheetParts we need to extract the displayCommodityOrder from fmt, which is a Maybe. This must be Just whenhever layout == LayoutBareWide, but we cannot enforce this condition in types.

That is, I propose not to include this pull request, but maintain it closed for further discussion.

However, the first commit 5fe4e4a swaps parameters of setDisplayCommodityBare, which I now think is more idiomatic. I think we should apply this one.

[simonmichael]

Ok @thielema.

[simonmichael]

I'm fine with keeping things as they are for now. But from the warning it sounds like a potential source of future bugs:

It's meaningless for 4 of the 5 layouts, and it carries an unenforced invariant: it must be a superset of every commodity rendered, because orderedAmounts silently drops amounts whose commodity isn't in displayCommodityOrder. Violating it doesn't crash, it prints zeros.

so maybe we should mention it briefly in a dev comment at least.