fix: write the five-field Approval block on version reset - #52
Merged
Merged
Conversation
Complete the three merged tasks (9acf57, 985164, e7c041) and tombstone siblings 88e04c / 172455 as covered by the archive umbrella.
hooks/version no longer refuses when - Status: is missing; it rewrites the ## Approval body to the same five lines hooks/task promote emits, in template order. Skill's human record snippet gains - Status: approved. Smoke asserts the full block and covers the four-field fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
hooks/version's Approval reset emit the same five-field blockhooks/taskpromote writes, so the plan gate and the version reset agreeon shape. A plan that followed the old four-field skill snippet (no
- Status:) previously madeversionrefuse; it now writes the fullblock instead. Skill's human record snippet gains
- Status: approved.Smoke locks the five-line order and covers the missing-Status fixture.
TaskFlow traceability
TaskFlowDocs/2026-09-23-version-approval-shape/hooks/version(presence gate, reset awk, post-check);skills/taskflow/SKILL.mdapproval snippet;hooks/smoke-testversion section + four-field fixture
mainhkwuks/TaskFlowVerification
bash hooks/smoke-test→ALL SMOKE PASSEDgit diff --check→ cleanquick_validate.py skills/taskflow→ Skill is valid;claude plugin validate . --strict→ passReview boundaries
(
454ac4remains out of scope; non-field lines inside## Approvalare left alone)