Skip to content

fix: write the five-field Approval block on version reset - #52

Merged
hkwuks merged 2 commits into
mainfrom
fix/version-approval-shape
Sep 22, 2026
Merged

hkwuks merged 2 commits into
mainfrom
fix/version-approval-shape

Conversation

@hkwuks

@hkwuks hkwuks commented Sep 22, 2026

Copy link
Copy Markdown
Owner

Summary

Make hooks/version's Approval reset emit the same five-field block
hooks/task promote writes, so the plan gate and the version reset agree
on shape. A plan that followed the old four-field skill snippet (no
- Status:) previously made version refuse; it now writes the full
block instead. Skill's human record snippet gains - Status: approved.
Smoke locks the five-line order and covers the missing-Status fixture.

TaskFlow traceability

  • Task: TaskFlowDocs/2026-09-23-version-approval-shape/
  • Scope: hooks/version (presence gate, reset awk, post-check);
    skills/taskflow/SKILL.md approval snippet; hooks/smoke-test
    version section + four-field fixture
  • Base branch: main
  • Target repository: hkwuks/TaskFlow

Verification

  • bash hooks/smoke-testALL SMOKE PASSED
  • git diff --check → clean
  • Relevant Skill/plugin validation → quick_validate.py skills/taskflow → Skill is valid; claude plugin validate . --strict → pass
  • Results recorded in the TaskFlow Plan

Review boundaries

  • No secrets or opaque remote payloads included
  • No unrelated task or user files changed
  • Remote/base assumptions are stated
  • Known limitations and follow-ups are documented
    (454ac4 remains out of scope; non-field lines inside ## Approval
    are left alone)

Complete the three merged tasks (9acf57, 985164, e7c041) and tombstone
siblings 88e04c / 172455 as covered by the archive umbrella.
hooks/version no longer refuses when - Status: is missing; it rewrites
the ## Approval body to the same five lines hooks/task promote emits,
in template order. Skill's human record snippet gains - Status: approved.
Smoke asserts the full block and covers the four-field fixture.
@hkwuks
hkwuks merged commit a817f89 into main Sep 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant