Skip to content

fix: print the full entry body from task get - #49

Merged
hkwuks merged 1 commit into
mainfrom
fix/task-get-notes
Sep 22, 2026
Merged

hkwuks merged 1 commit into
mainfrom
fix/task-get-notes

Conversation

@hkwuks

@hkwuks hkwuks commented Sep 22, 2026

Copy link
Copy Markdown
Owner

Summary

hooks/task get only printed lines that start with - at column 0. Notes continuations — usually indented, with or without a dash — were dropped with no warning. A caller reading one entry saw a complete-looking field list while the later bullets were missing, then decided on a truncated Notes block.

entry now prints every non-blank line of the section body, verbatim and in file order. Internal TASKFLOW_CMD=get (title + selected keys) is untouched; its three call sites keep that shape.

TaskFlow traceability

  • Task: TaskFlowDocs/2026-09-22-task-get-notes/
  • Todo item: TF-20260918-9acf57
  • Scope: hooks/task (entry branch only), hooks/smoke-test (Notes fixture in the get section), task documents, TaskFlowDocs/todo.md status
  • Base branch: main
  • Target repository: hkwuks/TaskFlow (origin)

Verification

  • bash hooks/smoke-testALL SMOKE PASSED
  • git diff --check — clean
  • Relevant Skill/plugin validation — quick_validate.py skills/taskflowSkill is valid!; no skill file is touched
  • Results recorded in the TaskFlow Plan — TaskFlowDocs/2026-09-22-task-get-notes/plan.md, ## Verification / Review

Beyond the suite: reproduction fixture printed all three Notes lines after the fix; grep -c 'TASKFLOW_CMD=get' still 3; existing get assertions (verbatim ID→Updated slice, no sibling/heading/blank, positional ID, read-only, unknown ID, next round-trip) stay green.

Review boundaries

  • No secrets or opaque remote payloads included
  • No unrelated task or user files changed — only the entry filter, its smoke block, and this task's documents/status
  • Remote/base assumptions are stated — pushed to origin (hkwuks/TaskFlow), targeting main
  • Known limitations and follow-ups are documented below

Known limitations

  • notes_end (used by task next when appending a bullet) still ends the block at a column-0 - only, so an indented Notes line can make the next bullet land mid-block. Same family, write path; out of scope here (PRD Q2).
  • Printing every non-blank body line will also print a future non-field line a hand edit puts inside an entry. That is intentional: get is a raw body read, not a schema printer.

hooks/task entry only emitted lines starting with "- " at column 0, so
indented Notes continuations (with or without a dash) vanished with no
warning. A caller reading one entry looked complete while missing later
bullets.

Print every non-blank line in the section body instead. Internal
TASKFLOW_CMD=get (title + selected keys) is unchanged; its three call
sites keep that shape.

Smoke adds a Notes fixture covering an indented bullet and an indented
no-dash line, asserts both appear, and diffs the body verbatim.
@hkwuks
hkwuks merged commit 86a6a24 into main Sep 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant