fix: print the full entry body from task get - #49
Merged
Merged
Conversation
hooks/task entry only emitted lines starting with "- " at column 0, so indented Notes continuations (with or without a dash) vanished with no warning. A caller reading one entry looked complete while missing later bullets. Print every non-blank line in the section body instead. Internal TASKFLOW_CMD=get (title + selected keys) is unchanged; its three call sites keep that shape. Smoke adds a Notes fixture covering an indented bullet and an indented no-dash line, asserts both appear, and diffs the body verbatim.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hooks/task getonly printed lines that start with-at column 0. Notes continuations — usually indented, with or without a dash — were dropped with no warning. A caller reading one entry saw a complete-looking field list while the later bullets were missing, then decided on a truncated Notes block.entrynow prints every non-blank line of the section body, verbatim and in file order. InternalTASKFLOW_CMD=get(title + selected keys) is untouched; its three call sites keep that shape.TaskFlow traceability
TaskFlowDocs/2026-09-22-task-get-notes/TF-20260918-9acf57hooks/task(entrybranch only),hooks/smoke-test(Notes fixture in the get section), task documents,TaskFlowDocs/todo.mdstatusmainhkwuks/TaskFlow(origin)Verification
bash hooks/smoke-test—ALL SMOKE PASSEDgit diff --check— cleanquick_validate.py skills/taskflow→Skill is valid!; no skill file is touchedTaskFlowDocs/2026-09-22-task-get-notes/plan.md,## Verification / ReviewBeyond the suite: reproduction fixture printed all three Notes lines after the fix;
grep -c 'TASKFLOW_CMD=get'still 3; existing get assertions (verbatim ID→Updated slice, no sibling/heading/blank, positional ID, read-only, unknown ID,nextround-trip) stay green.Review boundaries
entryfilter, its smoke block, and this task's documents/statusorigin(hkwuks/TaskFlow), targetingmainKnown limitations
notes_end(used bytask nextwhen appending a bullet) still ends the block at a column-0-only, so an indented Notes line can make the next bullet land mid-block. Same family, write path; out of scope here (PRD Q2).getis a raw body read, not a schema printer.