Repository navigation
Docs: fix stale reported version alpha9 -> alpha11 - #239
Merged
Merged
Conversation
The interpreter reports 1.13.0-alpha11 (core.rs native_clojure_version literal and ns.rs *clojure-version* map, both pinned by tests), but README.md and rust/core-coverage.md still claimed alpha9. Update the three reported-version claims to match the code. Oracle-version references (alpha9 jars/oracle matrices in docs and tests) are a different meaning and are untouched. AI-Tool: Muse Code (Meta Muse Spark) Session: gentle-menkar Signed-off-by: Hao Hu <hao.hu.fr@gmail.com>
Coverage report: 100.00% (lines)Threshold 100%: PASS (enforced by the quality gates).
Lowest 15 of 99 files. Full HTML report: download the Updated by the quality gates run on every push. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
michael-h-hu
approved these changes
Nov 4, 2026
michael-h-hu
left a comment
Collaborator
There was a problem hiding this comment.
Review: APPROVE (no findings)
Docs-only change, verified against code ground truth:
- Inspected: full diff (3 lines:
README.md:5,rust/core-coverage.md:8,rust/core-coverage.md:568) plus call sites —rust/crates/clj-eval/src/core.rsnative_clojure_versionreturns"1.13.0-alpha11"andrust/crates/clj-eval/src/ns.rsclojure_version_mapbuilds:qualifier "alpha11". - Test pinning:
rust/crates/clj-repl/tests/session.rsasserts(clojure-version)prints"1.13.0-alpha11"and qualifieralpha11;rust/crates/clj-eval/tests/control.rspins the same literal. Docs claiming alpha9 contradicted tested behavior. - Scope check: all three edits are reported-version claims (the port's own reported version). Oracle-version references (alpha9 jars/oracle matrices in
docs/, tests,CHANGELOG.mdhistory) name the JVM oracle — different meaning — correctly untouched. No otheralpha9remains in the two touched files. - CI: all PR checks green at review time (see verdict comment); master CI was already green with stale doc strings, confirming no test cross-asserts doc text, so this edits-3-lines change is safe.
Residual risk: none identified. The *clojure-version* row note ("plain root version map") carries no literal and needed no edit.
AI-Tool: Muse Code (Meta Muse Spark)
Session: gentle-menkar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only fix:
README.mdandrust/core-coverage.mdstill claim the port reports Clojure1.13.0-alpha9, but the interpreter reports1.13.0-alpha11.Mechanism proof
rust/crates/clj-eval/src/core.rsnative_clojure_versionreturns"1.13.0-alpha11", andrust/crates/clj-eval/src/ns.rsclojure_version_mapbuilds{:major 1, :minor 13, :incremental 0, :qualifier "alpha11"}for*clojure-version*.ns.rsmap is pinned by tests to alpha11, so docs claiming alpha9 contradict tested behavior.Changes (3 lines)
README.md:clojure-versionstill reports1.13.0-alpha9->1.13.0-alpha11rust/core-coverage.md(header): port reports Clojure1.13.0-alpha9->1.13.0-alpha11rust/core-coverage.md(clojure-version row): port release literal"1.13.0-alpha9"->"1.13.0-alpha11"Oracle-version references (alpha9 jars / oracle matrices in
docs/, tests, and history inCHANGELOG.md) name the JVM oracle version — a different meaning — and are intentionally untouched.AI-Tool: Muse Code (Meta Muse Spark)
Session: gentle-menkar