Skip to content

Docs: fix stale reported version alpha9 -> alpha11 - #239

Merged
m-hu merged 1 commit into
masterfrom
docs/version-alpha11
Nov 4, 2026
Merged

m-hu merged 1 commit into
masterfrom
docs/version-alpha11

Conversation

@m-hu

@m-hu m-hu commented Nov 4, 2026

Copy link
Copy Markdown

Summary

Docs-only fix: README.md and rust/core-coverage.md still claim the port reports Clojure 1.13.0-alpha9, but the interpreter reports 1.13.0-alpha11.

Mechanism proof

  • Ground truth is code, not docs: rust/crates/clj-eval/src/core.rs native_clojure_version returns "1.13.0-alpha11", and rust/crates/clj-eval/src/ns.rs clojure_version_map builds {:major 1, :minor 13, :incremental 0, :qualifier "alpha11"} for *clojure-version*.
  • The ns.rs map is pinned by tests to alpha11, so docs claiming alpha9 contradict tested behavior.
  • Master CI is green while the doc strings said alpha9, proving no test cross-asserts the doc strings — doc edits cannot break CI.

Changes (3 lines)

  • README.md: clojure-version still reports 1.13.0-alpha9 -> 1.13.0-alpha11
  • rust/core-coverage.md (header): port reports Clojure 1.13.0-alpha9 -> 1.13.0-alpha11
  • rust/core-coverage.md (clojure-version row): port release literal "1.13.0-alpha9" -> "1.13.0-alpha11"

Oracle-version references (alpha9 jars / oracle matrices in docs/, tests, and history in CHANGELOG.md) name the JVM oracle version — a different meaning — and are intentionally untouched.

AI-Tool: Muse Code (Meta Muse Spark)
Session: gentle-menkar

The interpreter reports 1.13.0-alpha11 (core.rs native_clojure_version literal and ns.rs *clojure-version* map, both pinned by tests), but README.md and rust/core-coverage.md still claimed alpha9. Update the three reported-version claims to match the code. Oracle-version references (alpha9 jars/oracle matrices in docs and tests) are a different meaning and are untouched.

AI-Tool: Muse Code (Meta Muse Spark)
Session: gentle-menkar
Signed-off-by: Hao Hu <hao.hu.fr@gmail.com>
@m-hu
m-hu requested a review from michael-h-hu as a code owner November 4, 2026 14:47
@m-hu m-hu added the session:gentle-menkar Owned by AI session gentle-menkar label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

Coverage report: 100.00% (lines)

Threshold 100%: PASS (enforced by the quality gates).

File Lines Hit %%
rust/crates/clj-aot/src/driver.rs 31 31 100.00%
rust/crates/clj-aot/src/jit.rs 156 156 100.00%
rust/crates/clj-aot/src/lib.rs 72 72 100.00%
rust/crates/clj-aot/src/link.rs 246 246 100.00%
rust/crates/clj-aot/src/lower.rs 785 785 100.00%
rust/crates/clj-aot/src/target.rs 48 48 100.00%
rust/crates/clj-core/src/lib.rs 3 3 100.00%
rust/crates/clj-eval/src/aot_subset.rs 2027 2027 100.00%
rust/crates/clj-eval/src/arrays.rs 1123 1123 100.00%
rust/crates/clj-eval/src/async.rs 1125 1125 100.00%
rust/crates/clj-eval/src/builtin_expand.rs 358 358 100.00%
rust/crates/clj-eval/src/classemu.rs 3580 3580 100.00%
rust/crates/clj-eval/src/coll.rs 2090 2090 100.00%
rust/crates/clj-eval/src/collmisc.rs 784 784 100.00%
rust/crates/clj-eval/src/compiler.rs 211 211 100.00%

Lowest 15 of 99 files. Full HTML report: download the coverage-report artifact.

Updated by the quality gates run on every push.

@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@michael-h-hu michael-h-hu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: APPROVE (no findings)

Docs-only change, verified against code ground truth:

  • Inspected: full diff (3 lines: README.md:5, rust/core-coverage.md:8, rust/core-coverage.md:568) plus call sites — rust/crates/clj-eval/src/core.rs native_clojure_version returns "1.13.0-alpha11" and rust/crates/clj-eval/src/ns.rs clojure_version_map builds :qualifier "alpha11".
  • Test pinning: rust/crates/clj-repl/tests/session.rs asserts (clojure-version) prints "1.13.0-alpha11" and qualifier alpha11; rust/crates/clj-eval/tests/control.rs pins the same literal. Docs claiming alpha9 contradicted tested behavior.
  • Scope check: all three edits are reported-version claims (the port's own reported version). Oracle-version references (alpha9 jars/oracle matrices in docs/, tests, CHANGELOG.md history) name the JVM oracle — different meaning — correctly untouched. No other alpha9 remains in the two touched files.
  • CI: all PR checks green at review time (see verdict comment); master CI was already green with stale doc strings, confirming no test cross-asserts doc text, so this edits-3-lines change is safe.

Residual risk: none identified. The *clojure-version* row note ("plain root version map") carries no literal and needed no edit.

AI-Tool: Muse Code (Meta Muse Spark)
Session: gentle-menkar

@m-hu
m-hu merged commit c4d9793 into master Nov 4, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

session:gentle-menkar Owned by AI session gentle-menkar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants