Skip to content

Add RS slow legs for boyer_moore, suffix_tree, segment_tree (#227) - #50

Closed
m-hu wants to merge 1 commit into
fix/40-comparabilityfrom
fix/227-rs-slow-legs
Closed

m-hu wants to merge 1 commit into
fix/40-comparabilityfrom
fix/227-rs-slow-legs

Conversation

@m-hu

@m-hu m-hu commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Stacked on #47 — adds the 3 missing clojure-rs slow legs that #47's
JVM-side matrix doesn't cover. Needed to close out #227's data gaps.

Evidence (master run 41790758885, authoritative merged BMFs)

  • RS boyer_moore/substring_searching: 7/7 cases TIMEOUT (>900s),
    callgrind measures null — still missing.
  • RS suffix_tree/string_function_calculation: 5/5 cases timeout,
    measures null — still missing.
  • RS segment_tree/range_minimum_query: recovered this run but flaky,
    and shows a x133 allocated_bytes jump (26.1 → 3478.9 GB, Ir x4.25,
    cpu 17 → 262s) — same #222 packing-quadratic family as the 9
    bisected regressions; needs a stable leg to confirm the #234 fix.

Change

  • 3 new perf-callgrind-slow legs (--timeout 3600 --jobs 2):
    rs boyer_moore, rs suffix_tree/string_function_calculation,
    rs segment_tree/range_minimum_query.
  • Matching 3 entries in the rs SLOW_EXCLUDE list (now 7 entries).

Validation

  • Each --only/--exclude pattern verified 1:1 against the real
    394-benchmark universe; YAML parses; JVM side untouched.
  • CI on this PR runs the new legs — green means the numbers exist.

AI-Tool: Muse Code (Meta Muse Spark)

Master run 41790758885 confirms the RS-side gaps persist: boyer_moore
(7 cases) and suffix_tree/string_function_calculation (5 cases) still
TIMEOUT (>900s) with null callgrind measures, and segment_tree recovered
only flakily while showing a x133 allocated_bytes jump (26.1 -> 3478.9 GB)
that needs a stable leg to confirm the #234 fix. Extends the #47 slow
matrix with the 3 missing clojure-rs legs and matching SLOW_EXCLUDE
entries; patterns verified 1:1 against the 394-benchmark universe.

AI-Tool: Muse Code (Meta Muse Spark)
@m-hu

m-hu commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

Closing per maintainer direction: clojure-rs slow legs will be solved in the runtime, not excluded. Tracked in hhh-pa/clojure#235. Branch kept for reference.

@m-hu m-hu closed this Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🐰 Bencher Report

Projectclojure-code-snippet
Branchfix/227-rs-slow-legs
Testbedubuntu-latest-clojure-rs

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
Benchmarkcallgrind_allocated_bytesMeasure (units) x 1e9callgrind_instructionsMeasure (units) x 1e12
string_related/trie/no_prefix_set📈 view plot
⚠️ NO THRESHOLD
128.97 units x 1e9📈 view plot
🚷 view threshold
2.00 units x 1e12
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant