Repository navigation
Conversation
Each perf-callgrind run resolves the upstream revision once but all 8 clojure-rs legs still check out + build it from scratch. Cache the release binary in actions/cache keyed by runner OS + resolved SHA so repeat runs skip toolchain, checkout, and build; a .rev marker file fails the leg loudly if a cached binary ever mismatches the revision. AI-Tool: Muse Code (Meta Muse Spark)
Collaborator
Author
|
Superseded by #45 — merged into the single batch PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caches the built clojure-rs release binary in
actions/cache, keyed byrunner OS + the resolve-rs SHA, so the 8
perf-callgrindclojure-rs legsskip toolchain install, checkout, and
cargo buildwhenever the upstreamrevision hasn't moved.
How it works
Restore cached clojure-rs binarystep (actions/cache@v5, sameaction family already used for jars) restores
cljrs-bin/on keycljrs-bin-<os>-<resolved-sha>.cache miss; the build stamps a
.revmarker with the SHA it built.Use clojure-rs binarystep runs on hit AND miss: it verifiesthe marker matches the resolved revision (fails loudly on mismatch
instead of benchmarking the wrong commit) and puts
cljrs-binon PATH.save the same immutable key (first wins, rest warn harmlessly).
Validation
gate — expect a miss-build on this run and hits on the next run that
resolves the same upstream SHA.
AI-Tool: Muse Code (Meta Muse Spark)