Repository navigation
Conversation
- min_cost_max_flow: sorted-vector heap re-sorted per pop -> java.util.PriorityQueue (pop O(h log h) -> O(log h)) - blossom, gale_shapley, second_best_mst, spfa: vector queue copied per dequeue -> PersistentQueue (dequeue O(n) -> O(1) amortized) - dag_shortest_paths: topo vector re-sorted per vertex + O(n) acc-membership scan per edge -> PriorityQueue + seen vector (poll O(h log h)+scan -> O(log h)+O(1)) Validation: 38 hand-built before/after runs (small + adversarial), all byte-identical; e.g. gale n=1500 11.2s->2.3s, spfa star60k 7.4s->0.7s, dag indep20k 4.2s->0.4s, mcmf n=300 10.1s->3.9s, sbmst star250 5.4s->2.0s. AI-Tool: Muse Code (Meta Muse Spark)
Collaborator
Author
|
Superseded by #45 — all four area branches merged into one batch PR. |
|
Bencher Report| Project | clojure-code-snippet |
| Branch | fix/39-graph-complexity |
| Testbed | ubuntu-latest-clojure-rs |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #39 — the six graph items: every BFS/queue dequeue and heap pop
that cost an extra linear factor now runs in the python twin's complexity.
Changes
graph/flow/min_cost_max_flow: Dijkstra heap pop O(h log h) re-sort →O(log h)
java.util.PriorityQueue(complete-DAG n=300: 10.1s → 3.9s).graph/matching/blossom,graph/matching/gale_shapley,graph/minimum_spanning_tree/second_best_mst,graph/shortest_path/spfa:O(n)
(vec rest)/ vec-concat dequeue → O(1)PersistentQueuepop/peek (gale_shapley n=1500: 11.2s → 2.3s; spfa star n=60000:
7.4s → 0.7s; second_best_mst n=250: 5.4s → 2.0s).
graph/shortest_path/dag_shortest_paths: topo poll re-sort + O(n)acc-scan → O(log h) PQ + O(1) seen-vector (edgeless n=20000:
4.2s → 0.4s).
FIFO/order semantics preserved (PQ ascending order = prior sort order).
Validation
clojure.mainonhand-built small + adversarial inputs (shared GPG cases unavailable
locally — full
run_tests.py+ perf-callgrind coverage comes from CIon this PR).
.cljfiles touched.AI-Tool: Muse Code (Meta Muse Spark)