Repository navigation
Float perf-callgrind native leg on clojure-rs master HEAD - #38
Merged
Merged
Conversation
Resolve the clojure-rs revision once per run instead of building a pinned SHA, so the sweep always measures current upstream. A single resolve-rs job publishes the SHA to all 16 legs (consistent even if master moves mid-sweep); manual dispatch may pin clojure_rs_sha to bisect or repro. README updated to match. AI-Tool: Muse Code 1.4.14-R7309.1 (Meta Muse Spark
|
Bencher Report| Project | clojure-code-snippet |
| Branch | float-clojure-rs-head |
| Commit | e7e0cad |
| Report | Testbed | Adapter | Status |
|---|---|---|---|
| 1 | ubuntu-latest-clojure-rs | JSON | ✅ No Alerts |
| 2 | ubuntu-latest-jvm | JSON | ✅ No Alerts |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The perf-callgrind native leg builds a pinned
CLOJURE_RS_SHA, so the sweep keeps measuring a stale upstream until someone manually bumps the pin and lands a revision for it.Solution
Float on clojure-rs master HEAD, resolved once per run:
resolve-rsjob:git ls-remoteon upstream HEAD (validates 40-hex, fails loudly otherwise), publishesshaoutput, records it in the step summary. A manual dispatch may setclojure_rs_shato pin for bisection/repro.perf-callgrindgainsneeds: [test, resolve-rs]and checks outneeds.resolve-rs.outputs.sha, so all 16 legs build the same commit even if upstream moves mid-sweep (~6h window). No added latency:resolve-rs(~10s) runs alongside the test shards.CLOJURE_RS_SHAenv removed; comments + README updated.Branch:
float-clojure-rs-head.No regressions
test, bothreport-callgrindfan-ins) unchanged.runtime_versionin the BMF), so floating revisions stay attributable on Bencher.AI-Tool: Muse Code 1.4.14-R7309.1 (Meta Muse Spark)
Test Plan
go test/gates apply.python3 yaml.safe_loadparses; jobs/needs/outputs verified (perf-callgrindneeds[test, resolve-rs],resolve-rsoutputssha);git diff --checkclean.