refactor!: final pass at adding pg commands from pg-extras plugin to cli PR 3 of 3#3780
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We need to move the commands from the pg-extras plugin to the core CLI, which will require us to update the commands to use oclif/core v4 and heroku-cli-command v12.
This is PR 3 of 3 and final to accomplish this task and we will be merging these PRs in feature/migrate_pg_extras_to_cli
Commands migrated:
Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
The --help changes (should be limited to --prompt and GLOBAL FLAGS additions that came with cli upgrades) ALSO examples as the cli requires:
diff <(./bin/run pg:table-size --help) <(heroku pg:table-size --help)
diff <(./bin/run pg:total-index-size --help) <(heroku pg:total-index-size --help)
diff <(./bin/run pg:total-table-size --help) <(heroku pg:total-table-size --help)
diff <(./bin/run pg:unused-indexes --help) <(heroku pg:unused-indexes --help)
diff <(./bin/run pg:user-connections --help) <(heroku pg:user-connections --help)
diff <(./bin/run pg:vacuum-stats --help) <(heroku pg:vacuum-stats --help)
New Command Testing Steps:
./bin/run pg:table-size -a $APP
./bin/run pg:table_size -a $APP
./bin/run pg:total-index-size -a $APP
./bin/run pg:total_index_size -a $APP
./bin/run pg:total-table-size -a $APP
./bin/run pg:total_table_size -a $APP
./bin/run pg:unused-indexes -a $APP
./bin/run pg:unused_indexes -a $APP
./bin/run pg:user-connections -a $APP
./bin/run pg:user_connections -a $APP
./bin/run pg:vacuum-stats -a $APP
Screenshots (if applicable)
Related Issues
GUS work item: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002YzlNjYAJ/view