Repository navigation
Conversation
…henmedia#1231) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The capsule case @marcus040473 suggested on #1324, as a small pull request on main as you asked: the rod was the only test that pins "keep straight on", and a round top guards that choice better.
Summary
capsulehelper (a cylinder with half spheres at both ends, closed and wound outward, ascylinderbeside it) and one test: "Layerling" turned on end near the capsule's top comes out whole, torn at no point, and the mesh closed.refined(). On the rod the letters lie clearly more whole straight on (0.955 against 0.535), so the wholeness decides; on the capsule they lie as whole either way (0.718), withinWHOLE_MARGIN, and straight on is kept because it tears less (0 points against 36).Testing
On 005885d (on main at d7550dc):
npm test -- tests/unit/surfaceTextureText.test.ts(22 tests) andnpm run typecheckif (false && over.creased): torn 36) and when the choice is reversed; passes unchanged, three runs, about 0.7 s.🤖 Generated with Claude Code