Repository navigation
docs(notifications): Review and approve call to action and approval details (EN+ES) - #184
Merged
Merged
Conversation
…ils, actions_url/approve_url/workspace/approval fields (EN+ES) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…total vs actions, Open in NaN on digests, ES wording QA and UX review nits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates
/docs/notifications(EN and ES) for helmcode/nan-cloud-api#351.?approval=1, also after signing in). It says you never approve from Slack, Teams or Discord, and covers the closed-approval case.approval.pendingexample, and the fields table gets rows forworkspace,actions_url,approve_url,approvaland its subfields.approval_pendingfixtures.notificationsDocs.test.ts. New assertions for the CTA labels, the provider shapes, the documentedapproval.pendingbody against the golden, and the new field rows. The Teams button label is nowView run.Tests
npm testpasses (86 files, 2532 tests) andnpm run buildpasses.🤖 Generated with Claude Code