Skip to content

docs(notifications): Review and approve call to action and approval details (EN+ES) - #184

Merged
sre-helmcode merged 2 commits into
mainfrom
docs/notif-approval-cta
Oct 14, 2026
Merged

sre-helmcode merged 2 commits into
mainfrom
docs/notif-approval-cta

Conversation

@sre-helmcode

Copy link
Copy Markdown
Contributor

What

Updates /docs/notifications (EN and ES) for helmcode/nan-cloud-api#351.

  • Channels table. It now describes the per-event buttons: Review and approve, View run, Open automation and View triggers. For Discord it explains the bold link, since webhooks cannot render buttons.
  • New section "Approval messages" / "Mensajes de aprobación". It lists what an approval message shows (automation, workspace, expiry, kinds, up to 5 actions as kind and target) and explains that the button opens the run with the proposal focused (?approval=1, also after signing in). It says you never approve from Slack, Teams or Discord, and covers the closed-approval case.
  • Payload. The run.failed example gets the new fields. There is a new approval.pending example, and the fields table gets rows for workspace, actions_url, approve_url, approval and its subfields.
  • "What a message never carries". New bullet: action bodies, titles, commit messages, labels and the diff are never included.
  • Fixtures. Golden files re-copied byte-identical from cloud-api, plus the Slack, Teams and Discord approval_pending fixtures.
  • notificationsDocs.test.ts. New assertions for the CTA labels, the provider shapes, the documented approval.pending body against the golden, and the new field rows. The Teams button label is now View run.

Tests

npm test passes (86 files, 2532 tests) and npm run build passes.

🤖 Generated with Claude Code

barckcode and others added 2 commits October 14, 2026 20:52
…ils, actions_url/approve_url/workspace/approval fields (EN+ES)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…total vs actions, Open in NaN on digests, ES wording

QA and UX review nits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sre-helmcode
sre-helmcode merged commit 1278e8c into main Oct 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants