Repository navigation
fix(waitlist): treat USA and LATAM as open regions and stop showing the position - #141
Merged
Merged
Conversation
3 tasks
…he position
USA and LATAM are open regions now, but the form still showed them the
"not open in your region yet" text: registerViaBackend derived an
`interest` status from the region. The success message also showed a
"position" that was a cumulative arrival counter, not a place in the
queue, over a fake total equal to itself.
All regions now get the same registered message, the `interest` status
and its copy are gone, and the position is no longer shown nor forwarded
by the Worker (`{ ok, status: 'registered', region }`). Cached old JS
reads the missing fields as 0 and still shows the registered message.
Closes #140
crstian19
force-pushed
the
fix/140-waitlist-regions-position
branch
from
October 2, 2026 10:57
13103ea to
4ae0e6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140
Why
USA and LATAM are open regions now. A signup from there is stored as a normal waitlist signup, the same as EU. But the form still showed USA and LATAM the text for a region that isn't open yet ("Noted. We are not open in your region yet…").
The form also showed a "position" (
position 019 / 19) that was misleading:Product decided to drop the position from the message.
What
registerViaBackendno longer derivesstatusfrom the region, in either the 201 or the 409 answer. Theintereststatus and itsokInterestcopy (EN and ES) are removed.positionandtotalare dropped from the/api/waitlistresponse, which is now{ok, status: 'registered', region}.okPositionis removed from the copy.position/totalas 0, so it shows the registered message without a position.status: 'registered'keeps it off the old "not open" branch.src/lib/waitlist.tsis updated.community-signup, the confirmation email and the premium flow (?premium=1) don't read these fields, so they are unchanged.Docs
ARCHITECTURE.mdnow documents the new response,{ ok, status: 'registered', region }, with all regions open and no position.Test
npm test: 1337 tests in 66 files pass.npm run check: 0 errors, 0 warnings, 0 hints.npm run buildpasses.waitlistSuccessTextno longer takes the response, so no field the Worker sends can reach the message. One test per language (EN and ES, real i18n copy) asserts the exact registered text, with no position fragment and no "not open" text.position,totalandstatus: 'interest'.status: 'registered'for USA and LATAM on both 201 and 409, and doesn't forward the backend counter.Hero.astroserialises intodata-msgscontainokPositionorokInterest.okRegisteredremoved;okPosition/okInterestbrought back to i18n, the script orHero.astro;interestderived from the region again, in the 201 and the 409 answer;main, given the new response, shows the registered message for EU, USA and LATAM in EN and ES, without a position and without crashing.