Skip to content

cloud-api: unbounded HTTP method label in request metrics #172

Closed

Description

@sre-helmcode

Found by the Security review of nan-cloud-api#337. The method label of the cloud-api HTTP request metrics takes arbitrary HTTP methods from clients, so anyone can create unbounded series (cardinality). Fix: map anything outside the standard methods to OTHER, with a test. Follow-up from QA: pin the /nan_whk_AAAAAAAAnan_whk_BBBBBBBB path case in the logger redaction tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions