Repository navigation
fix: handle failed local searches explicitly in continuous sampling - #51
Merged
Merged
Conversation
) A local search fails when minimize raises ValueError or returns a non-finite fitness. A failed initial search fails its run; a failed search after a perturbation is rejected and counts as non-improving. Results with success=False but finite fitness are still used. - record minimizer success/status/message in raw_records - add BasinHoppingResult.run_summary with per-run status - warn once per sample() when any local search failed - StepSizeEstimator: divide by evaluated perturbations, skip failed samples, raise RuntimeError when nothing can be evaluated
Warnings raised in joblib worker processes never reached the parent, so failed local searches were invisible with n_jobs > 1. Workers now return caught warnings and the parent re-emits them. Also drop stale comments and a dead finiteness check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44