Fix issue with Tone mode not using the correct frequency on page load#4
Open
schui wants to merge 1 commit into
Open
Fix issue with Tone mode not using the correct frequency on page load#4schui wants to merge 1 commit into
schui wants to merge 1 commit into
Conversation
Author
|
If you fresh load the page and never change the frequency, Tone mode plays constants.DEFAULT_FREQ instead of the selected frequency. If the tab is left open for a while, and is discarded by the browser, then it also acts like it is a fresh load. You can force a discard with chrome://discards/ Steps:
|
Author
|
Thanks for reviewing the change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3 Wrong frequency in tone mode when page is left open for a while