Repository navigation
flux: Add setting to allow actions on Flux-managed resources - #1366
Open
DhruvShetty22 wants to merge 2 commits into
Open
DhruvShetty22 wants to merge 2 commits into
DhruvShetty22 wants to merge 2 commits into
Conversation
Since 0.7.0 the plugin hides Edit, Scale, Delete and Rollback on resources managed by Flux, to avoid drifting from the state in Git. Some users rely on those actions to try out changes in test or QA clusters. Add an "allowFluxManagedActions" setting, off by default, under a new "Resource actions" section in the plugin settings, with a note that Flux reverts such changes. It is wired up to the header actions in the next commit. Signed-off-by: Dhruv Shetty <sdhruv23@iitk.ac.in>
When "allowFluxManagedActions" is on, keep the Edit, Scale, Delete and Rollback header actions on Flux-managed resources instead of hiding them. The "Flux managed" chip stays, in warning colour, with a tooltip saying that changes will be reverted on the next reconciliation, so users still know they are changing a resource that Flux owns. The read-only View YAML button is only added when the edit actions are hidden, as Edit already shows the YAML. With the setting off, which is the default, nothing changes. Move the processing into processFluxHeaderActions() so it can be unit tested without registering the processor, and document the setting in the README. Signed-off-by: Dhruv Shetty <sdhruv23@iitk.ac.in>
DhruvShetty22
requested review from
ashu8912,
illume,
joaquimrocha,
skoeva,
sniok,
vyncent-t and
yolossn
as code owners
October 17, 2026 13:19
Author
|
@illume Tagging you for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since flux 0.7.0 (#579), the Edit, Scale, Delete and Rollback actions are hidden on resources managed by Flux, to avoid drift from the state in Git.
This PR adds an opt-in plugin setting, off by default, that brings those actions back. The "Flux managed" chip stays visible as a reminder that Flux will revert the changes.
Fixes #1293
Screenshots
Before:
After:
Setting:
Notes for the Reviewer