Repository navigation
knative: eventing: Add Channel and Subscription detail pages - #1355
Closed
RajPrakash681 wants to merge 2 commits into
Closed
RajPrakash681 wants to merge 2 commits into
RajPrakash681 wants to merge 2 commits into
Conversation
Signed-off-by: RajPrakash681 <rjnt452@gmail.com>
Signed-off-by: RajPrakash681 <rjnt452@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds detail pages for Knative Channels and Subscriptions, following the list views in #1354. Selecting a Channel or Subscription now opens a page that shows how events flow through it, instead of Headlamp's generic Custom Resource view.
This branch is built on #1354, so until #1354 merges the diff here also shows its commit. Only the last commit,
knative: eventing: Add Channel and Subscription detail pages, is new.Related Issue
Part of #922
Depends on #1354
Changes
InMemoryChannel/orders), its address, and a Subscriptions section with the state the Channel reports for each subscriber. Knative identifies subscribers by UID, so each one is matched to the Subscription with that UID in the Channel's namespace and linked to its page; a subscriber without a match shows its UID.-, so objects on a cluster that has only the CRDs still render. Channels and Subscriptions that Knative created and owns stay read-only, as in knative: eventing: Add Channel and Subscription list views #1354.KnativeChannelandKnativeSubscriptionname their owndetailsRouteandlistRoute, so names in the lists, the Channel links on Subscription rows and pages, Headlamp's Back button and the navigation after a delete lead to the plugin's pages.EventingResourceDetailpage and the route check inKnativeCustomResourceare the same as in knative: eventing: Add Broker and Trigger detail pages #1353, which adds the Broker and Trigger pages; here the shared page also accepts sections after the conditions. Whichever of the two merges second will be rebased onto the other.Steps to Test
cd knative && npm run tsc && npm run lint && npm test../test-files/setup-eventing.sh, open Knative > Eventing > Channels and selectorders. The page showsInMemoryChannel/orders, the Channel's address, andorders-to-displayunder Subscriptions asTrue.orders-to-display. It linksChannel/orders,Service/event-displayandBroker/default, and shows the resolved subscriber and reply URIs. SelectingChannel/ordersopens the Channel page.default-…Subscriptions: "Controlled by" shows its Trigger, and Edit and Delete are not offered.Screenshots
Taken in Headlamp's dark theme at 2x zoom, with the sidebar collapsed.
Channel page: the backing Channel and the address.
A Channel's Subscriptions: each subscriber with its Subscription's name and state.
Subscription page: the Channel, subscriber, reply, and the endpoints Knative resolved.
A Subscription a Broker created: controlled by its Trigger, and read-only.