Velero/backup coverage phase 2

[Pragati5-DEBUG]

Summary

Adds Phase 2 cluster-wide Velero views for Headlamp (kubernetes-sigs/headlamp#5198), building on Phase 1 coverage panels (#877).

• Sidebar Velero with Schedules, Backups, and Coverage gaps
• Schedule / Backup list + detail pages (cron, status, next run, last backup, phase, triggered-by)
• Coverage gaps: namespaces and Deployments/StatefulSets with no matching Schedule
• Coverage / schedule views load Backups via velero.io/schedule-name label selector (latest per schedule), addressing the Phase 2 scale note from review — Backups list still shows the full table
• Velero sidebar icon + install check empty state
• Test fixtures for Schedules / Backups demo

Test plan

• cd velero && npm test (and Prettier/lint clean)
• Apply fixtures (test-files/) on a cluster with Velero CRDs
• Sidebar → Velero → Schedules / Backups / Coverage gaps load
• Schedule detail shows cron, next run, last backup when Backup CRs exist
• Coverage gaps lists uncovered namespaces/workloads
• Deployment/STS/PVC/Namespace detail panels still show Phase 1 coverage
• Settings → Plugins → Velero namespace still filters Schedule/Backup lists

Screen.Recording.2026-10-03.131847.mp4

[Copilot]

Copilot review overview

🟡 Changes recommended

The promised Coverage gaps view is absent, and selector, scaling, and coverage edge cases remain unresolved.

Review effort: Balanced
Findings: 2 · 3 · 2

Open (7)

• Handle malformed namespace globs without crashing · New
• Use a valid no-match selector for empty schedules · New
• Avoid fetching full backup history for latest-per-schedule results · New
• Add the missing coverage gaps view and route · New
• Support schedule-based restore sources · New
• Update catalog entry to reflect Phase 2 pages · New
• Document applying Backup and Restore fixtures · New

What changed in this PR

Adds a read-only Velero plugin with contextual backup coverage and cluster-wide resource views.

Changes:

• Adds Schedule, Backup, and Restore list/detail pages and navigation.
• Implements coverage matching, cron calculations, status display, and filtered backup loading.
• Adds configuration, tests, documentation, and manual fixtures.

File	Description
velero/​tsconfig.json	Configures TypeScript.
velero/​test-files/​web-label-only-schedule.yaml	Adds label-based Schedule fixture.
velero/​test-files/​sample-schedule.yaml	Adds Schedule and Deployment fixtures.
velero/​test-files/​sample-restores.yaml	Adds Restore fixtures.
velero/​test-files/​sample-backups.yaml	Adds Backup fixtures.
velero/​test-files/​README.md	Documents fixture usage.
velero/​test-files/​matching-cases.yaml	Adds coverage-matching scenarios.
velero/​src/​veleroIcon.ts	Registers the Velero icon.
velero/​src/​utils/​veleroRoutes.ts	Defines route names and paths.
velero/​src/​utils/​status.ts	Maps Velero phases to status colors.
velero/​src/​utils/​backupQuery.ts	Builds Backup label selectors.
velero/​src/​utils/​backupQuery.test.ts	Tests selector generation.
velero/​src/​storybook.test.tsx	Enables story snapshots.
velero/​src/​settings.tsx	Adds namespace settings UI.
velero/​src/​resources/​velero.ts	Defines Velero resource models.
velero/​src/​index.tsx	Registers navigation, routes, and panels.
velero/​src/​hooks/​useVeleroInstalled.ts	Detects the Velero API.
velero/​src/​hooks/​useVeleroData.ts	Loads and joins Schedule/Backup data.
velero/​src/​headlamp-plugin.d.ts	Adds plugin type references.
velero/​src/​cron.ts	Parses schedules and calculates next runs.
velero/​src/​cron.test.ts	Tests cron utilities.
velero/​src/​coverage.ts	Implements coverage matching.
velero/​src/​coverage.test.ts	Tests coverage behavior.
velero/​src/​config.ts	Defines plugin configuration.
velero/​src/​components/​schedules/​List.tsx	Adds the Schedule list.
velero/​src/​components/​schedules/​Detail.tsx	Adds Schedule details.
velero/​src/​components/​restores/​List.tsx	Adds the Restore list.
velero/​src/​components/​restores/​Detail.tsx	Adds Restore details.
velero/​src/​components/​common/​VeleroInstallCheck.tsx	Adds installation gating.
velero/​src/​components/​backups/​List.tsx	Adds the Backup list.
velero/​src/​components/​backups/​Detail.tsx	Adds Backup details.
velero/​src/​components/​BackupCoveragePanelPure.tsx	Renders coverage states and results.
velero/​src/​components/​BackupCoveragePanel.tsx	Connects resource panels to Velero data.
velero/​src/​components/​BackupCoveragePanel.stories.tsx	Adds coverage panel stories.
velero/​README.md	Documents the plugin.
velero/​package.json	Defines package scripts and dependencies.
velero/​.gitignore	Ignores generated artifacts.
README.md	Adds Velero to the plugin catalog.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

The Coverage gaps view is missing, and namespace filtering, write controls, schedule validation, and interval cron handling need correction.

Review effort: Balanced
Findings: 5

Open (5)

• Pin backups fetch to configured namespace and disable actions · New
• Pin restores fetch to configured namespace and disable actions · New
• Pin schedules fetch to configured namespace and disable actions · New
• Support Velero @​every schedules in next-run parsing · New
• Handle failed schedules and exclude them from coverage · New

Resolved since last review (7)

• Use a valid no-match selector for empty schedules
• Handle malformed namespace globs without crashing
• Support schedule-based restore sources
• Add the missing coverage gaps view and route
• Avoid fetching full backup history for latest-per-schedule results
• Document applying Backup and Restore fixtures
• Update catalog entry to reflect Phase 2 pages

[Pragati5-DEBUG]

Copilot flagged missing Coverage gaps ,that was intentional. Phase 2 for this PR is Schedules / Backups / Restores only (per #939); Coverage gaps are deferred.

[illume]

Thanks for these changes.

It looks like this PR has git conflicts. Can you please fix them?

How to resolve conflicts

Rebase or merge the latest main into your branch, resolve the conflicts, and push the updated branch.

Can you please have a look at the git commits to see if they meet the contribution guidelines? We use a Linux kernel style of git commits. See the contributing guide for general context, and please see previous git commits with git log for examples.

Commits that need attention

• velero: Fix CRON_TZ regex for TypeScript target — Only one file changed inside velero/; add a sub-area so it's clear what was touched (e.g. velero: ComponentName: description).

Commit guidelines

• Use atomic commits focused on a single change.
• Use the title format <area>: <Description of changes> — description must start with a capital letter.
• Keep the title under 72 characters (soft requirement).
• Explain the intention and why the change is needed.
• Make commit titles meaningful and describe what changed.
• Do not add code that a later commit rewrites; squash or reorder commits instead.
• Do not include Fixes #NN in commit messages.

Good examples:

• ai-assistant: ai-ui: HomeButton: Fix so it navigates to home
• kueue: Metrics: Add new way to see what is happening

[Copilot]

🟡 Changes recommended

Coverage false positives, the missing coverage-gap view, and an unsafe Restore fixture must be addressed.

1 open finding

• Prevent fixture from triggering a real restore · New

5 resolved since last review

• Handle failed schedules and exclude them from coverage
• Support Velero @​every schedules in next-run parsing
• Pin schedules fetch to configured namespace and disable actions
• Pin restores fetch to configured namespace and disable actions
• Pin backups fetch to configured namespace and disable actions

Previously missed (2)

In code that hasn't changed since last review

Honor Velero namespace-scoped resource filters

velero/​src/​coverage.ts:85

The coverage matcher ignores Velero's namespace-scoped resource filters. Schedule.spec.template is a BackupSpec, which also supports includedNamespaceScopedResources and excludedNamespaceScopedResources; for example, a schedule with excludedNamespaceScopedResources: [deployments.apps] is currently reported as covering a Deployment even though Velero excludes it. Model and evaluate those filters before reporting workload or namespace coverage.

Correct the contradictory expected coverage result

velero/​test-files/​README.md:40

This expected result contradicts the prescribed fixture set: web-label-only-schedule.yaml selects Deployments in default with app: web, exactly matching case-label-web. After running the commands above, this Deployment is covered, so the manual check currently reports a false failure.

🧠 Review effort: Balanced

[Pragati5-DEBUG]

Conflicts on #1326 are resolved (merged latest main), and the CRON_TZ commit title is updated to velero: cron: Fix CRON_TZ regex for TypeScript target. Ready for another look when you have a moment.

[illume]

Thanks for this PR.

the PR has a merge-main commit; please rebase against main to keep the history clean.

Why this matters

Merge commits from main make the PR history harder to review. Please rebase your branch on top of the latest main instead, then update the PR with the rebased commits.

[Copilot]

🟡 Changes recommended

The advertised Coverage gaps view is absent, and several schedule status and latest-backup states can be reported inaccurately.

4 open findings

• Detail page hides Backup loading and errors · New
• Backup loading and errors render as None · New
• Use creation timestamp for pre-execution Backups · New
• Unknown schedule phases incorrectly map to Active · New

1 resolved since last review

• Prevent fixture from triggering a real restore

🧠 Review effort: Balanced

[Pragati5-DEBUG]

Ready for another look when you have a moment

[Copilot]

🟡 Changes recommended

Unresolved read-only behavior, coverage matching, scheduling, and namespace-scoping issues can expose unintended actions or misleading backup information.

5 open findings

• Disable default detail-page actions on read-only resource pages · New
• Use route namespace consistently for schedules and backups · New
• Restore qualified singular workload resource aliases · New
• Preserve lastSkipped when calculating next-run times · New
• Restore namespaced-resource eligibility for coverage · New

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

Backup and Restore detail pages expose mutation controls despite the plugin’s documented read-only scope.

7 open findings

• Disable default Edit/Delete actions on Backup details · New
• Disable default Edit/Delete actions on Restore details · New
• Disable default detail-page actions on read-only resource pages
• Restore namespaced-resource eligibility for coverage
• Preserve lastSkipped when calculating next-run times
• Restore qualified singular workload resource aliases
• Use route namespace consistently for schedules and backups

🧠 Review effort: Balanced

[Copilot]

🔵 Needs a closer look

Namespace filtering and live-query scope need correction and integration validation before human approval.

0 open findings

7 resolved since last review

• Disable default Edit/Delete actions on Restore details
• Disable default Edit/Delete actions on Backup details
• Disable default detail-page actions on read-only resource pages
• Restore namespaced-resource eligibility for coverage
• Preserve lastSkipped when calculating next-run times
• Restore qualified singular workload resource aliases
• Use route namespace consistently for schedules and backups

Previously missed (2)

In code that hasn't changed since last review

Scope Backup history requests to the current Schedule

velero/​src/​components/​schedules/​Detail.tsx:19

This page needs the latest Backup only for the route's Schedule, but useVeleroData(namespace) lists every Schedule and requests retained Backup history for all of them. With many schedules or long retention periods, opening one detail page transfers and watches unrelated histories before reducing them client-side. Add an optional schedule-name scope to the hook and pass name here so this page selects only this schedule's Backups, without requiring the full Schedule list to build that selector.

Ignore global namespace filtering for Velero resource lists

velero/​src/​components/​schedules/​List.tsx:30

noNamespaceFilter hides the selector but does not disable ResourceListView's default namespace filtering. If default is selected on another page, rows fetched from the configured velero namespace disappear, with no visible control to clear that filter. This affects Schedules, Backups, and Restores. Give all three lists a search-preserving filterFunction that ignores the global namespace selection, since their requests are already scoped by the plugin setting. Verify navigation from a differently filtered page and confirm text search still works.

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

Hidden namespace filtering and missing cluster context can hide resources or display and navigate to resources from the wrong cluster.

3 open issues

• Preserve cluster context in related-resource links · New
• Disable global namespace filtering on resource lists · New
• Key backup lookups by cluster and schedule · New

1 file not reviewed

• velero/package-lock.json: Generated file

_{Review effort: Balanced}

[illume]

🎉 thanks!