Skip to content

Fix ESP32 UART reader thread spinning at 100% CPU #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TekTrails wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ESP32 UART reader thread spinning at 100% CPU #637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/driver/esp32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ static void *pthread_recv_esp32(void *arg) {
int i, len = 0;
uint8_t buffer[128];
fd_set rd;
struct timeval tv = {0, 100000};
struct timeval tv;

// Init UART buffers
uart3_rptr = 0;
Expand All @@ -48,6 +48,11 @@ static void *pthread_recv_esp32(void *arg) {
for (;;) {
FD_ZERO(&rd);
FD_SET(fd_esp32, &rd);
// On Linux, select() overwrites tv with the time left; once it has
// timed out it stays {0, 0} and select() returns immediately, so the
// timeout has to be re-armed on every iteration.
tv.tv_sec = 0;
tv.tv_usec = 100000;
if (stopping) {
LOGI("UART3:stopping, exiting thread.");
return NULL;
Expand All @@ -71,8 +76,10 @@ static void *pthread_recv_esp32(void *arg) {
}
if (len)
esp32_rx();
} else
esp32_handler_timeout();
}
// Delayed DVR command: check it on every wake-up, not only on timeout,
// or a backpack talking more often than every 100 ms would hold it off.
esp32_handler_timeout();
}
return NULL;
}
Expand Down