Skip to content

FE-788: add form row to ds#8831

Merged
alex-e-leon merged 23 commits into
mainfrom
FE-788-add-form-row-to-ds
Jun 5, 2026
Merged

FE-788: add form row to ds#8831
alex-e-leon merged 23 commits into
mainfrom
FE-788-add-form-row-to-ds

Conversation

@alex-e-leon
Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

  • Add FormRow component to ds
  • Add connectToLeftInput and connectToRightInput props to BaseInput

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Jun 5, 2026 1:19pm
hashdotdesign-tokens Ready Ready Preview, Comment Jun 5, 2026 1:19pm
petrinaut Ready Ready Preview, Comment Jun 5, 2026 1:19pm

@cursor
Copy link
Copy Markdown

cursor Bot commented Jun 5, 2026

PR Summary

Medium Risk
Touches shared BaseInput styling and adds new public DS APIs; visual regressions on existing TextInput/NumberInput usages are possible though behavior is additive.

Overview
Adds FormRow to lay out multiple Form.Field children in a flex row, with gap (mdxl, spaceBetween, none), align, optional row-level errors, and noWrap. Form stories cover default layouts, gap variants (including gap="none" with connected inputs), and alignment.

BaseInput / TextInput gain connectToLeftInput and connectToRightInput (default variant only) so adjacent inputs render as a segmented control via a new InputConnector SVG and wrapper padding. Styling moves backgrounds/borders to a --base-input-background-color CSS variable (neutral/red tokens instead of legacy bd-solid / status tokens) so hover, disabled, invalid, and adornment states stay in sync with connectors.

Ladle stories document FormRow and connected input matrix (states, sizes, suffix buttons).

Reviewed by Cursor Bugbot for commit ebf73c1. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/apps > hash.design Affects the `hash.design` design site (app) labels Jun 5, 2026
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 07492ab. Configure here.

@alex-e-leon alex-e-leon added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit 819c96f Jun 5, 2026
47 checks passed
@alex-e-leon alex-e-leon deleted the FE-788-add-form-row-to-ds branch June 5, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants