Skip to content

BE-474: HashQL: Take into account terminator target eligibility in execution backend placement#8587

Merged
indietyp merged 10 commits into
mainfrom
bm/be-474-hashql-take-into-account-terminators-eligibility-when
May 26, 2026
Merged

BE-474: HashQL: Take into account terminator target eligibility in execution backend placement#8587
indietyp merged 10 commits into
mainfrom
bm/be-474-hashql-take-into-account-terminators-eligibility-when

Conversation

@indietyp
Copy link
Copy Markdown
Member

🌟 What is the purpose of this PR?

🔗 Related links

  • ...

🚫 Blocked by

  • ...

🔍 What does this change?

  • ...

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

⚠️ Known issues

🐾 Next steps

🛡 What tests cover this?

❓ How to test this?

  1. Checkout the branch / view the deployment
  2. Try X
  3. Confirm that Y

📹 Demo

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment May 26, 2026 7:34am
petrinaut Ready Ready Preview May 26, 2026 7:34am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
hashdotdesign Ignored Ignored Preview May 26, 2026 7:34am
hashdotdesign-tokens Ignored Ignored Preview May 26, 2026 7:34am

Copy link
Copy Markdown
Member Author

indietyp commented Mar 26, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 92.97297% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.83%. Comparing base (cb459a8) to head (65a8a94).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ass/execution/statement_placement/embedding/mod.rs 53.12% 15 Missing ⚠️
libs/@local/hashql/mir/src/pretty/text.rs 75.00% 7 Missing ⚠️
...cal/hashql/mir/src/pass/execution/splitting/mod.rs 97.01% 1 Missing and 1 partial ⚠️
...pass/execution/statement_placement/postgres/mod.rs 93.75% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8587      +/-   ##
==========================================
+ Coverage   58.81%   58.83%   +0.02%     
==========================================
  Files        1328     1329       +1     
  Lines      126811   127250     +439     
  Branches     5790     5797       +7     
==========================================
+ Hits        74580    74867     +287     
- Misses      51350    51500     +150     
- Partials      881      883       +2     
Flag Coverage Δ
apps.hash-api 0.00% <ø> (ø)
local.hash-backend-utils 2.81% <ø> (ø)
rust.hash-graph-api 2.52% <ø> (ø)
rust.hashql-compiletest 28.26% <ø> (-1.38%) ⬇️
rust.hashql-core 79.32% <100.00%> (+0.06%) ⬆️
rust.hashql-hir 89.06% <ø> (ø)
rust.hashql-mir 86.80% <91.50%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 26, 2026

Merging this PR will not alter performance

✅ 80 untouched benchmarks


Comparing bm/be-474-hashql-take-into-account-terminators-eligibility-when (65a8a94) with main (ae5c317)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (cb459a8) during the generation of this report, so ae5c317 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 31, 2026

Deployment failed with the following error:

Invalid request: `attribution.gitUser` should NOT have additional property `isBot`.

@indietyp indietyp force-pushed the bm/be-474-hashql-take-into-account-terminators-eligibility-when branch from 2add45e to e6a3adb Compare April 29, 2026 15:51
@indietyp indietyp force-pushed the bm/be-455-hashql-create-evaluation-target-coordinator branch from 83bf74a to e30f552 Compare April 29, 2026 15:51
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Apr 29, 2026

🤖 Augment PR Summary

Summary: Updates HashQL execution planning so backend placement accounts for whether a block’s terminator can run on a target (and what it costs), not just the block’s statements.

Changes:

  • Adds `FiniteBitSet::is_superset` / `is_subset` helpers (with tests) to compare target domains.
  • Introduces per-block TerminatorCostVec and threads terminator costs through statement placement, block splitting, and cost aggregation.
  • Extends basic-block splitting to optionally peel off a dedicated “terminator region” when terminator support is narrower/incomparable vs the last statement region.
  • Ensures synthesized split-chain Goto terminators get zero terminator cost via TerminatorCostVec::remap tests.
  • Renames/clarifies transition-matrix costs to TerminatorTransitionCostVec for the solver/AC-3 path, separating “transition costs” from “terminator execution costs”.
  • Updates MIR text formatting to support terminator annotations, and refreshes UI/snapshot expectations accordingly.
  • Adjusts eval UI postgres outputs to reflect updated planning/continuation SQL generation.

Notes: This touches core placement/solver inputs (domains, splitting, cost aggregation), so correctness hinges on terminator eligibility being represented consistently across targets and after splitting.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread libs/@local/hashql/mir/src/pass/execution/cost/mod.rs
Comment thread libs/@local/hashql/eval/tests/ui/postgres/constant-true-filter.aux.mir.orig Outdated
Comment thread libs/@local/hashql/eval/tests/ui/orchestrator/.spec.toml
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 53b27a5. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

policy_resolution_large

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 2002 $$27.2 \mathrm{ms} \pm 187 \mathrm{μs}\left({\color{gray}-3.900 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$3.39 \mathrm{ms} \pm 16.8 \mathrm{μs}\left({\color{gray}-1.440 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 1001 $$12.3 \mathrm{ms} \pm 84.1 \mathrm{μs}\left({\color{gray}-3.621 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: high, policies: 3314 $$42.7 \mathrm{ms} \pm 326 \mathrm{μs}\left({\color{gray}-2.325 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: low, policies: 1 $$14.1 \mathrm{ms} \pm 92.8 \mathrm{μs}\left({\color{gray}-1.390 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: medium, policies: 1526 $$24.1 \mathrm{ms} \pm 162 \mathrm{μs}\left({\color{gray}0.055 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 2078 $$28.0 \mathrm{ms} \pm 185 \mathrm{μs}\left({\color{lightgreen}-5.704 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$3.68 \mathrm{ms} \pm 21.7 \mathrm{μs}\left({\color{gray}-2.628 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 1033 $$13.4 \mathrm{ms} \pm 108 \mathrm{μs}\left({\color{gray}-2.315 \mathrm{\%}}\right) $$ Flame Graph

policy_resolution_medium

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 102 $$3.83 \mathrm{ms} \pm 24.4 \mathrm{μs}\left({\color{gray}-0.863 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$3.02 \mathrm{ms} \pm 18.9 \mathrm{μs}\left({\color{gray}-0.891 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 51 $$3.40 \mathrm{ms} \pm 19.3 \mathrm{μs}\left({\color{gray}0.096 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: high, policies: 269 $$5.24 \mathrm{ms} \pm 31.8 \mathrm{μs}\left({\color{gray}-1.154 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: low, policies: 1 $$3.51 \mathrm{ms} \pm 16.9 \mathrm{μs}\left({\color{gray}-2.499 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: medium, policies: 107 $$4.15 \mathrm{ms} \pm 27.6 \mathrm{μs}\left({\color{gray}-2.968 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 133 $$4.45 \mathrm{ms} \pm 30.7 \mathrm{μs}\left({\color{gray}-1.405 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$3.41 \mathrm{ms} \pm 18.8 \mathrm{μs}\left({\color{lightgreen}-5.947 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 63 $$4.21 \mathrm{ms} \pm 28.2 \mathrm{μs}\left({\color{gray}1.34 \mathrm{\%}}\right) $$ Flame Graph

policy_resolution_none

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 2 $$2.71 \mathrm{ms} \pm 17.4 \mathrm{μs}\left({\color{gray}-2.192 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$2.65 \mathrm{ms} \pm 13.3 \mathrm{μs}\left({\color{gray}-1.226 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 1 $$2.76 \mathrm{ms} \pm 14.7 \mathrm{μs}\left({\color{gray}-1.060 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 8 $$3.02 \mathrm{ms} \pm 14.7 \mathrm{μs}\left({\color{gray}-1.583 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$2.84 \mathrm{ms} \pm 15.5 \mathrm{μs}\left({\color{gray}-0.552 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 3 $$3.15 \mathrm{ms} \pm 18.8 \mathrm{μs}\left({\color{gray}-0.184 \mathrm{\%}}\right) $$ Flame Graph

policy_resolution_small

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 52 $$3.09 \mathrm{ms} \pm 19.0 \mathrm{μs}\left({\color{gray}-0.764 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$2.77 \mathrm{ms} \pm 14.1 \mathrm{μs}\left({\color{gray}-1.141 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 25 $$2.94 \mathrm{ms} \pm 15.1 \mathrm{μs}\left({\color{gray}-0.748 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: high, policies: 94 $$3.55 \mathrm{ms} \pm 18.3 \mathrm{μs}\left({\color{gray}-0.282 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: low, policies: 1 $$3.04 \mathrm{ms} \pm 14.5 \mathrm{μs}\left({\color{gray}-0.731 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: medium, policies: 26 $$3.29 \mathrm{ms} \pm 16.5 \mathrm{μs}\left({\color{gray}-1.800 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 66 $$3.44 \mathrm{ms} \pm 16.5 \mathrm{μs}\left({\color{gray}-0.928 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$3.05 \mathrm{ms} \pm 17.6 \mathrm{μs}\left({\color{gray}-0.685 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 29 $$3.35 \mathrm{ms} \pm 18.8 \mathrm{μs}\left({\color{gray}-1.403 \mathrm{\%}}\right) $$ Flame Graph

read_scaling_complete

Function Value Mean Flame graphs
entity_by_id;one_depth 1 entities $$44.9 \mathrm{ms} \pm 190 \mathrm{μs}\left({\color{gray}0.952 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 10 entities $$84.7 \mathrm{ms} \pm 414 \mathrm{μs}\left({\color{gray}1.32 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 25 entities $$50.2 \mathrm{ms} \pm 302 \mathrm{μs}\left({\color{gray}-1.080 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 5 entities $$54.4 \mathrm{ms} \pm 392 \mathrm{μs}\left({\color{gray}4.00 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 50 entities $$63.8 \mathrm{ms} \pm 352 \mathrm{μs}\left({\color{gray}4.81 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 1 entities $$46.9 \mathrm{ms} \pm 249 \mathrm{μs}\left({\color{gray}0.871 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 10 entities $$430 \mathrm{ms} \pm 1.25 \mathrm{ms}\left({\color{gray}-0.786 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 25 entities $$101 \mathrm{ms} \pm 500 \mathrm{μs}\left({\color{gray}-0.793 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 5 entities $$92.9 \mathrm{ms} \pm 421 \mathrm{μs}\left({\color{gray}1.27 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 50 entities $$292 \mathrm{ms} \pm 960 \mathrm{μs}\left({\color{lightgreen}-9.296 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 1 entities $$19.3 \mathrm{ms} \pm 130 \mathrm{μs}\left({\color{gray}-2.973 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 10 entities $$19.9 \mathrm{ms} \pm 102 \mathrm{μs}\left({\color{gray}-2.772 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 25 entities $$20.1 \mathrm{ms} \pm 115 \mathrm{μs}\left({\color{gray}-4.543 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 5 entities $$20.1 \mathrm{ms} \pm 109 \mathrm{μs}\left({\color{gray}-1.819 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 50 entities $$24.2 \mathrm{ms} \pm 118 \mathrm{μs}\left({\color{gray}-2.351 \mathrm{\%}}\right) $$ Flame Graph

read_scaling_linkless

Function Value Mean Flame graphs
entity_by_id 1 entities $$19.5 \mathrm{ms} \pm 122 \mathrm{μs}\left({\color{gray}-0.922 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$19.7 \mathrm{ms} \pm 100 \mathrm{μs}\left({\color{gray}-1.436 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$19.6 \mathrm{ms} \pm 117 \mathrm{μs}\left({\color{gray}-2.530 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$20.3 \mathrm{ms} \pm 139 \mathrm{μs}\left({\color{gray}-2.092 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$27.0 \mathrm{ms} \pm 202 \mathrm{μs}\left({\color{gray}-3.249 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$37.9 \mathrm{ms} \pm 326 \mathrm{μs}\left({\color{gray}3.77 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$36.4 \mathrm{ms} \pm 272 \mathrm{μs}\left({\color{red}10.2 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$36.1 \mathrm{ms} \pm 327 \mathrm{μs}\left({\color{gray}-2.240 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$35.9 \mathrm{ms} \pm 319 \mathrm{μs}\left({\color{gray}3.84 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$36.6 \mathrm{ms} \pm 328 \mathrm{μs}\left({\color{red}12.5 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$37.2 \mathrm{ms} \pm 362 \mathrm{μs}\left({\color{gray}3.28 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$35.8 \mathrm{ms} \pm 329 \mathrm{μs}\left({\color{red}5.37 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$36.7 \mathrm{ms} \pm 349 \mathrm{μs}\left({\color{gray}0.608 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$35.2 \mathrm{ms} \pm 382 \mathrm{μs}\left({\color{gray}1.94 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: bf5a9ef5-dc3b-43cf-a291-6210c0321eba $$8.78 \mathrm{ms} \pm 44.6 \mathrm{μs}\left({\color{gray}3.53 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property traversal_paths=0 0 $$97.7 \mathrm{ms} \pm 556 \mathrm{μs}\left({\color{gray}3.44 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=255 1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true $$151 \mathrm{ms} \pm 778 \mathrm{μs}\left({\color{gray}4.20 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false $$104 \mathrm{ms} \pm 546 \mathrm{μs}\left({\color{gray}3.25 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true $$111 \mathrm{ms} \pm 518 \mathrm{μs}\left({\color{gray}1.79 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true $$121 \mathrm{ms} \pm 562 \mathrm{μs}\left({\color{gray}1.70 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true $$127 \mathrm{ms} \pm 533 \mathrm{μs}\left({\color{gray}1.91 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=0 0 $$104 \mathrm{ms} \pm 641 \mathrm{μs}\left({\color{gray}2.11 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=255 1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true $$135 \mathrm{ms} \pm 602 \mathrm{μs}\left({\color{gray}4.13 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false $$115 \mathrm{ms} \pm 513 \mathrm{μs}\left({\color{red}5.70 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true $$121 \mathrm{ms} \pm 556 \mathrm{μs}\left({\color{gray}2.94 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true $$123 \mathrm{ms} \pm 563 \mathrm{μs}\left({\color{gray}3.18 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true $$122 \mathrm{ms} \pm 514 \mathrm{μs}\left({\color{gray}2.29 \mathrm{\%}}\right) $$

scenarios

Function Value Mean Flame graphs
full_test query-limited $$134 \mathrm{ms} \pm 548 \mathrm{μs}\left({\color{lightgreen}-5.131 \mathrm{\%}}\right) $$ Flame Graph
full_test query-unlimited $$148 \mathrm{ms} \pm 508 \mathrm{μs}\left({\color{gray}-1.757 \mathrm{\%}}\right) $$ Flame Graph
linked_queries query-limited $$101 \mathrm{ms} \pm 1.42 \mathrm{ms}\left({\color{red}153 \mathrm{\%}}\right) $$ Flame Graph
linked_queries query-unlimited $$564 \mathrm{ms} \pm 1.22 \mathrm{ms}\left({\color{red}7.37 \mathrm{\%}}\right) $$ Flame Graph

Copy link
Copy Markdown
Contributor

@thehabbos007 thehabbos007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. These comments are not blocking a merge

Comment thread libs/@local/hashql/mir/src/pass/execution/cost/tests.rs
Comment thread libs/@local/hashql/mir/src/pass/execution/splitting/mod.rs
Comment thread libs/@local/hashql/mir/src/pass/execution/splitting/mod.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests type/eng > backend Owned by the @backend team

Development

Successfully merging this pull request may close these issues.

2 participants