fix: transferring ownership of pre-existing deployemnts#1177
Open
themariofrancia wants to merge 2 commits into
Open
fix: transferring ownership of pre-existing deployemnts#1177themariofrancia wants to merge 2 commits into
themariofrancia wants to merge 2 commits into
Conversation
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
themariofrancia
changed the title
marcosio
requested changes
May 22, 2026
| } | ||
| if (transferOwnership & (1 << 2) != 0) { | ||
| (Ownable(address(irs))).transferOwnership(_tokenDetails.owner); | ||
| } |
Contributor
There was a problem hiding this comment.
Please, use more than 3 words identifiers.
Create new functions to manipulate transferOwnership function and return true/false depending of the boolean to be check. Don't use magic numbers, create explicit constants with the functional meaning of each position on the uint256.
Function very complex, refatorize it to be clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Testing
Node version:
Checklist