Native Windows Folder picker - #13
Merged
Merged
Conversation
Replaced PowerShell folder picker with native Win32 folder picker for better integration in GUI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PS/Cmd shell file picker would intermittently not work. This pull request switches to native Win32 file/folder picker.
Changes:
#else
#include <direct.h>
#define COBJMACROS
#define INITGUID
#define Rectangle Win32_Rectangle
#define CloseWindow Win32_CloseWindow
#define ShowCursor Win32_ShowCursor
#include <shlobj.h>
#include <shobjidl.h>
#undef ShowCursor
#undef CloseWindow
#undef Rectangle
#endif
#elif defined(_WIN32) || defined(_WIN64)
// Native Win32 file picker - no PowerShell, no console required
OPENFILENAMEA ofn = {0};
ofn.lStructSize = sizeof(ofn);
ofn.lpstrFilter = "FLAC files\0*.flac\0All files\0*.*\0";
ofn.lpstrFile = picked;
ofn.nMaxFile = sizeof(picked);
ofn.lpstrTitle = "Select FLAC playback file";
ofn.Flags = OFN_FILEMUSTEXIST | OFN_PATHMUSTEXIST;
GetOpenFileNameA(&ofn);
trim_newlines(picked);