Resolve HSDOAH no-go - #12
Merged
Merged
Conversation
harrypm
added a commit
that referenced
this pull request
Jul 4, 2026
…RC + ChB on Linux/macOS PR #12 ("Resolve HSDOAH no-go", commit 2eaec01) added cflags += ['-DHSDAOH_UPSTREAM=1'] as a GLOBAL define across all platforms, but the HSDAOH_UPSTREAM code path in gui_capture.c is an incomplete WIP reference implementation: - it hard-disables MISRC simple-capture mode (gui_capture.c ~1407: returns -1 with "Simple-capture unavailable in HSDAOH_UPSTREAM build") - it has NO stream_id==1 (ChB) handler in gui_capture_upstream_callback, so channel B data is silently dropped - it skips gui_capture_configure_handler(app, true), so the MISRC frame parser is never initialized This broke HSDAOH/MISRC connect and CXADC ChB on Linux/macOS in v1.1.0. Make HSDAOH_UPSTREAM=1 Windows-only so Windows keeps PR #12's connect fix verbatim, and Linux/macOS restore the complete v1.0.9 MISRC raw-callback + frame-parser path (both channels). The Windows -lavrt/-lksuser GUI linker flags from the same commit are already Windows-gated and unchanged. Also add four HARD CI MIRROR RULES to AGENTS.MD after discovering a local-build validity gap: scripts/build-appimage-local.sh --native on a host with /usr/local/lib/libhsdaoh.so bundled a DIFFERENT libhsdaoh (sha 4b1204a0, has hsdaoh_open2) than the v1.0.9 CI release AppImage (sha f1d3b785, vendored, no hsdaoh_open2), because the 997cf05 vendored-hsdaoh rpath was shadowed by the system libFLAC's /usr/local/lib rpath. Per the new rules, that local build was non-representative of the CI/published artifact and its test was invalid; the HSDAOH_UPSTREAM fix must be validated against a CI-built AppImage. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor bug fix - meson.build - add ln 19: cflags += ['-DHSDAOH_UPSTREAM=1']