feat: integrate pl.strict testing and add to CI matrix per #35#53
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #53 +/- ##
========================================
Coverage 95.90% 95.90%
========================================
Files 18 18
Lines 1026 1026
========================================
Hits 984 984
Misses 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request integrates support for testing
luajsonunder Penlight's strict variable check module (pl.strict) and adds it to the CI test matrix.To make
pl.strictcompatible with the test suite (avoiding global lookup errors on optional globals inluacov,luarocks, andlunit), this change:luarocks,luacov, etc.) have loaded.TEST_STRICT=pl.strictis used, the hook pre-declares expected nil-check globals accessed byluacov,luarocks, andlunit._G's__indexto handle and skipnilkey lookups, preventing formatting crashes withinpl.strict.lua 5.3matrix item to run withstrict_module: "pl.strict".run_tests.shto installpenlightvia luarocks only whenTEST_STRICT=pl.strictis specified.Verification
TEST_STRICT=pl.strictlocally on Lua 5.3: