refactor(cli): extract cli/ module directory, consolidate routing - #4
Merged
Conversation
Both tests mutate the process-wide XDG_CONFIG_HOME env var, which dirs::config_dir() reads. When Rust's test runner executes them in parallel on different threads, one test's set_var stomps the other's temp dir, causing spurious assertion failures. Serialize with a static Mutex.
Replace per-function #[allow(clippy::print_stdout)] scattered across cli/ submodules with a single #[allow(...)] on the `pub mod cli` declaration in lib.rs. CLI handlers are the intended user-facing output sites.
Only hm and hm-plugin-cloud use these. Inline the version specs directly in each crate's Cargo.toml instead of routing through [workspace.dependencies].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.