feat(studio): polish command palette with keyboard-help focus fix - #286
Merged
Merged
Conversation
Skip unavailable commands during arrow navigation, tighten record-search chrome, fix stuck Search trigger focus after selection, and keep palette grid templates off the shared shortcuts dialog panel class. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df33c5b33a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #284 and closes #195. Preserves SaadNiaziDev's original command-palette commit and fixes focus restoration after selection: in-place commands, Keyboard shortcuts, and cancelled navigation retain the prior focus target. Successful navigation clears the stuck Search focus ring; commands that explicitly move focus keep control of their destination.
The follow-up fix could not be pushed to the contributor fork: the connected GitHub integration returned HTTP 403 despite maintainer edits being enabled. This upstream branch contains the original commit, focused fixes, and a merge of current main; #284 has not been merged.
Validation on final branch d39a9bd: all 98 Studio tests pass (0 failed, 0 skipped), TypeScript/Vite build and git diff --check pass. Chromium checks pass for disabled-command navigation, Enter selection, Escape focus restoration, in-place action focus, successful/cancelled navigation, Record search/Back, Keyboard shortcuts focus regression, and mobile bounds. Browser checks used real Studio components with mocked API responses. Current main removed obsolete tests, accounting for the count change from 101 on the original branch. Automated reviews completed; the in-place focus review concern was fixed and resolved. Full CI is rerunning on the final commit before merge.