Install Apps from Git repositories - #281
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change
dygo app installto accept a Git repository URL instead of requiring App source to exist in the project first.The command now shallow-clones the repository's default branch, requires
app.ymlat the repository root, and validates the App manifest and dependency set before prompting or writing project files. After confirmation it copies the checkout atomically toapps/<name>, excludes Git metadata, regenerates Hook and Job runner wiring, and removes the installed source if project-level validation or runner generation fails.--dry-runclones and validates without changing the project. Existing Apps, missing dependencies, reserved names, symbolic links, and unsupported file types are rejected. Database behavior is unchanged: installation never connects to PostgreSQL, anddygo db migrateremains the only path that applies App-owned database state.Migration diagnostics now direct stale Hook or Job wiring to
dygo hook sync, sincedygo app installrequires a repository URL.Validation
go test ./...go vet ./...go run ./cmd/dygo app install --helpCLI tests cover successful repository installation, dependency ordering, Git metadata exclusion, dry-run isolation, invalid repositories, missing dependencies, and rollback after project metadata validation fails.