Repository navigation
fix: make test script glob cross-platform for Windows - #1
Open
supunyasanthaofficial wants to merge 1 commit into
Open
supunyasanthaofficial wants to merge 1 commit into
supunyasanthaofficial wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
testscript inpackage.jsonwas not working correctly on Windows because the test glob pattern was wrapped in single quotes.Windows shells like CMD and PowerShell don't handle single quotes the same way as Unix shells. As a result, Node.js received the quotes as part of the path and couldn't find the test files, so no tests were executed.
Fix
Changed the single quotes to escaped double quotes:
Testing
Verified the fix on Windows using
pnpm test.