ci: add more pytest files and update cli to download root - #3
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the ssltui CLI with a new getroot subcommand for exporting the root CA certificate, and adds a broad set of end-to-end pytest coverage for CLI, TUI (tmux-driven), and REST API behavior.
Changes:
- Add
ssltui getrootCLI subcommand with optional--outfile output. - Add smoke, TUI lifecycle/init, API serve, and getroot CLI end-to-end tests.
- Document the new
getrootusage in the README.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
ssltui/__main__.py |
Adds getroot subcommand wiring and implementation. |
README.md |
Documents getroot command usage and intent (stdout PEM, stderr summary). |
tests/test_1_smoke.py |
Adds basic import/config/CLI help smoke coverage. |
tests/test_2_tui_init.py |
Adds tmux-driven CA init end-to-end test. |
tests/test_3_tui_cert_lifecycle.py |
Adds tmux-driven issue → save → revoke lifecycle test. |
tests/test_4_api_serve.py |
Adds end-to-end REST API tests against a real ssltui serve session. |
tests/test_5_getroot.py |
Adds CLI coverage for getroot stdout, --out, and uninitialised error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+393
to
+396
| # When writing to a terminal, print a short summary to stderr so stdout | ||
| # stays a clean PEM that can be piped or redirected. | ||
| if sys.stdout.isatty(): | ||
| try: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
pytestcasesgetrootsubcommand