Skip to content

ci: add more pytest files and update cli to download root - #3

Merged
hali-coding merged 1 commit into
mainfrom
ci/tests2
Jun 14, 2026
Merged

ci: add more pytest files and update cli to download root#3
hali-coding merged 1 commit into
mainfrom
ci/tests2

Conversation

@hali-coding

Copy link
Copy Markdown
Owner

Changes

  • Update pytest cases
  • Update cli command with new getroot subcommand

Copilot AI review requested due to automatic review settings June 14, 2026 14:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the ssltui CLI with a new getroot subcommand for exporting the root CA certificate, and adds a broad set of end-to-end pytest coverage for CLI, TUI (tmux-driven), and REST API behavior.

Changes:

  • Add ssltui getroot CLI subcommand with optional --out file output.
  • Add smoke, TUI lifecycle/init, API serve, and getroot CLI end-to-end tests.
  • Document the new getroot usage in the README.

Reviewed changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ssltui/__main__.py Adds getroot subcommand wiring and implementation.
README.md Documents getroot command usage and intent (stdout PEM, stderr summary).
tests/test_1_smoke.py Adds basic import/config/CLI help smoke coverage.
tests/test_2_tui_init.py Adds tmux-driven CA init end-to-end test.
tests/test_3_tui_cert_lifecycle.py Adds tmux-driven issue → save → revoke lifecycle test.
tests/test_4_api_serve.py Adds end-to-end REST API tests against a real ssltui serve session.
tests/test_5_getroot.py Adds CLI coverage for getroot stdout, --out, and uninitialised error.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ssltui/__main__.py
Comment on lines +393 to +396
# When writing to a terminal, print a short summary to stderr so stdout
# stays a clean PEM that can be piped or redirected.
if sys.stdout.isatty():
try:
@hali-coding
hali-coding merged commit ecf4d36 into main Jun 14, 2026
3 checks passed
@hali-coding
hali-coding deleted the ci/tests2 branch June 14, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants