Fix UI test feedback - #9402
Open
Aries-0331 wants to merge 6 commits into
Open
Conversation
seafile-dev
requested changes
Aug 19, 2026
seafile-dev
left a comment
seafile-dev
left a comment
Contributor
There was a problem hiding this comment.
Verdict: Request changes
Blocking:
- 依赖清单与锁文件版本不一致，
npm ci无法安装依赖；见行内评论。
Warnings:
- 未发现其他可由当前差异明确复现的功能性问题。
Aries-0331
force-pushed
the
fix/ui-feedback
branch
from
August 19, 2026 02:57
faf5f9d to
a91b4cf
Compare
seafile-dev
reviewed
Aug 19, 2026
seafile-dev
left a comment
seafile-dev
left a comment
Contributor
There was a problem hiding this comment.
Verdict: Comment
Blocking:
- 先前的依赖锁文件不一致已在当前提交中修复：
package.json与package-lock.json均解析为@seafile/seafile-calendar@1.0.14，干净执行npm ci --ignore-scripts成功。
Warnings:
- 新增了一个未使用的
DirView导入；见行内评论。
Suggested fix: 删除该导入，保持变更通过项目的 lint 检查。
added 2 commits
August 19, 2026 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.