⚡ Bolt: optimize synthetic embedding generation#267
Conversation
This commit improves the performance of synthetic embedding generation by leveraging Node 22's one-shot `crypto.hash` API, optimizing vector normalization with manual loops, and replacing expensive `toFixed` calls with mathematical rounding. Key changes: - Introduced `HAS_CRYPTO_HASH` to use high-performance one-shot hashing when available. - Refactored `syntheticVector` and `normalizeVector` to use manual `for` loops and pre-allocated arrays. - Replaced `toFixed(8)` with `Math.round(val * 1e8) / 1e8` for a significant speedup in rounding. - Added options to skip redundant text and vector normalization in `toEmbeddingVectorRecord`. Performance Impact: - Reduces synthetic embedding generation latency by ~58% (from ~887ms to ~366ms for 100 vectors). - Measurably improves efficiency of hot paths in the `@jeanbot/ai` package. Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Optimized synthetic embedding generation in
@jeanbot/ai.🎯 Why: The previous implementation used legacy streaming hash APIs, expensive string-based rounding (
toFixed), and high-overhead array methods (Array.from,.map,.reduce) in hot paths.📊 Impact: Expected performance improvement of ~58% in synthetic embedding generation latency.
🔬 Measurement: Verified with a local benchmark (
perf.test.ts) showing generation of 100 vectors dropped from ~887ms to ~366ms.PR created automatically by Jules for task 17649070898248322732 started by @hackerxj2010