Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix path traversal and prefix bypass in LocalJsonStore and TerminalService#265

Draft
hackerxj2010 wants to merge 1 commit into
mainfrom
sentinel/fix-path-traversal-prefix-bypass-1996626724564265253
Draft

πŸ›‘οΈ Sentinel: [HIGH] Fix path traversal and prefix bypass in LocalJsonStore and TerminalService#265
hackerxj2010 wants to merge 1 commit into
mainfrom
sentinel/fix-path-traversal-prefix-bypass-1996626724564265253

Conversation

@hackerxj2010

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability:

  • Path traversal in LocalJsonStore (packages/documents/src/index.ts) allowed access to files outside the intended base directory using .. segments.
  • Prefix bypass in TerminalService (services/terminal-service/src/index.ts) allowed accessing sibling directories that share a prefix with the allowed root (e.g., /app/workspace-secret vs /app/workspace).

🎯 Impact: Unauthorized file access or execution in arbitrary directories.

πŸ”§ Fix:

  • Hardened LocalJsonStore.toPath with segment validation for .. and absolute path prefix checking.
  • Updated TerminalService.resolveCwd to ensure trailing separators are present on both paths before performing the startsWith check.

βœ… Verification:

  • Added a security test for LocalJsonStore (verified and then removed as per plan).
  • Ran existing TerminalService unit tests.
  • Ran full monorepo test suite (48 tests passed).

PR created automatically by Jules for task 1996626724564265253 started by @hackerxj2010

This commit fixes two security vulnerabilities:
1. Path traversal in LocalJsonStore by adding segment validation and prefix check.
2. Prefix bypass in TerminalService by ensuring trailing separators before startsWith check.

Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant