π‘οΈ Sentinel: [HIGH] Fix path traversal and prefix bypass in LocalJsonStore and TerminalService#265
Conversation
This commit fixes two security vulnerabilities: 1. Path traversal in LocalJsonStore by adding segment validation and prefix check. 2. Prefix bypass in TerminalService by ensuring trailing separators before startsWith check. Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability:
LocalJsonStore(packages/documents/src/index.ts) allowed access to files outside the intended base directory using..segments.TerminalService(services/terminal-service/src/index.ts) allowed accessing sibling directories that share a prefix with the allowed root (e.g.,/app/workspace-secretvs/app/workspace).π― Impact: Unauthorized file access or execution in arbitrary directories.
π§ Fix:
LocalJsonStore.toPathwith segment validation for..and absolute path prefix checking.TerminalService.resolveCwdto ensure trailing separators are present on both paths before performing thestartsWithcheck.β Verification:
LocalJsonStore(verified and then removed as per plan).TerminalServiceunit tests.PR created automatically by Jules for task 1996626724564265253 started by @hackerxj2010