🛡️ Sentinel: [HIGH] Fix path traversal and prefix bypass vulnerabilities#261
Conversation
- Fixed path traversal in `LocalJsonStore` by blocking `..` segments and adding absolute path containment checks. - Fixed prefix bypass in `TerminalService.resolveCwd` by ensuring trailing separators in path containment checks. - Added comprehensive unit tests for both fixes. - Recorded learnings in `.jules/sentinel.md`. Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🛡️ Sentinel has identified and fixed two critical path-related vulnerabilities:
LocalJsonStore: TheLocalJsonStorewas vulnerable to path traversal through..injection in keys. I've updatedtoPathto explicitly block these segments and perform a robust absolute path prefix check to ensure all file operations stay within the base directory.TerminalService: TheresolveCwdmethod used a naivestartsWithcheck which was vulnerable to prefix bypass (e.g.,/workspace-secretwould match an allowed/workspace). I've implemented aensureTrailingSephelper to ensure correct directory-level containment checks.Both fixes have been verified with new and updated unit tests, and the full test suite passes.
PR created automatically by Jules for task 4939822673830252959 started by @hackerxj2010