Repository navigation
Claude/vigilant keller vghlxm - #2
Merged
Merged
Conversation
The first version drew its own egg: a lat/long shell generated from an exaggerated version of Marc's profile numbers. That was not what was asked for. This replaces it with the asset itself. - src/render/shell.js is Marc's src/client/egg/shell.js — the same SphereGeometry(1, 128, 96) through the same shapeEgg, wearing the same MeshPhysicalMaterial with its bump, clearcoat and sheen. - src/render/skin.js is his skin.js: 900 speckles painted onto a canvas, a colour map and a bump map off the same pass. - src/render/environment.js is his environment.js, and the stage's studio lights at their own intensities and directions. The rig travels with the shell so the light on it never drifts down the course. - src/core/shape.js is shapeEgg, verbatim, and nothing else. The egg is bigger (1.4m, against a 2m lane) so the asset reads at speed, and it rolls on its own half-height instead of a made-up radius. The world stays wireframe green; the egg is the only thing in it that is not made of lines. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A7kZFhN8q6WSvqXrjoWpht
The egg was coming out the wrong shape, two reasons. It tumbled end over end, so most frames caught it pointing at the camera or lying on its side. The silhouette — fat end down, narrow end up — is the whole asset, so it now stays upright: it rocks while it runs, turns slowly on the spot and leans into a lane change, the way Marc does. The squash spring was worse, and a real bug rather than a matter of taste. It is explicit Euler integrated on the raw frame delta, so a long frame did not slow it down, it blew it up: one hitch and the shell pinned at its limits and stayed there, alternating between a pancake and a capsule. It is sub-stepped at 1/120 now, and clamped so it can squash but barely stretch. Measured against the asset rather than eyeballed. The shaped shell is 0.818 wide for every 1 tall; on screen it was rendering 0.66 to 0.77, and now renders 0.813 to 0.845 — Marc's own page measures 0.834 the same way. Also drops the lens from 64° to 52°, since a wide lens stretches whatever sits away from the middle of the frame, and what sits there is the egg. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A7kZFhN8q6WSvqXrjoWpht
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix claudes stupidity from ignoring explicit instructions