Skip to content

docs(runtime): name both strict launchers - #165

Merged
0monish merged 1 commit into
mainfrom
agent/kel-176-launcher-rustdoc
Sep 4, 2026
Merged

docs(runtime): name both strict launchers#165
0monish merged 1 commit into
mainfrom
agent/kel-176-launcher-rustdoc

Conversation

@0monish

@0monish 0monish commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Correct run_linux_strict_launcher rustdoc to name both callers: the runtime-owned boundary-test binary and the shipping launcher staged beside keld-host.
  • Record why the two tiny Cargo entrypoints are distinct artifacts while all trusted parsing/Landlock/readiness/exec policy remains single-owned by the shared function.
  • Leave both binaries and every executable byte untouched.

Spec refs

  • KEL-176, refutation and narrow surviving fix for KEL-127 teardown leads DG-04/DN-04.
  • No boundary change: documentation only; containment, process, staging, permission, and wire behavior are unchanged.

Review gates

  • unsafe — none.
  • public API — applicable: corrects documentation on a public Linux-only function.
  • permission model — none.
  • dependency addition — none.
  • wire protocol — none.
  • CodeRabbit CLI 0.7.6 reviewed exact commit 468d5c2 against 9f19d3d with zero findings.

Tests

  • Source census proved both binary mains delegate to the same run_linux_strict_launcher; runtime tests consume CARGO_BIN_EXE_keld-linux-strict-launcher, while host tests/CLI staging consume keld-role-launcher.
  • cargo fmt --all --check and git diff --check passed.
  • Exact committed-tip isolated just ci — policy/generated-doc/Docker Mermaid gates, product-status 69/69, frozen TypeScript install/typecheck/41 tests, format, warning-denied workspace Clippy, 630/630 nextest with 2 intentional skips, rustdoc, and cargo-deny passed.

Platforms

  • Local macOS full repository gate passed, but the Linux-only public item is cfg-excluded from local rustdoc.
  • Hosted Ubuntu warning-denied rustdoc is required before merge; no unrun Linux result is claimed.

Perf impact

None. Comment-only change.

@keldrobo keldrobo added size/XS <10 lines type:docs Documentation only labels Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 54 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 5e4f255d-ab04-4a38-8a46-5ebde78512c8

📥 Commits

Reviewing files that changed from the base of the PR and between 9f19d3d and 468d5c2.

📒 Files selected for processing (1)
  • crates/keld-runtime/src/linux_strict.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@0monish
0monish merged commit b359fe0 into main Sep 4, 2026
16 checks passed
@0monish
0monish deleted the agent/kel-176-launcher-rustdoc branch September 4, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS <10 lines type:docs Documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants