Skip to content

Add distribution acceptance and complete Godot release archives - #163

Merged
link1345 merged 9 commits into
mainfrom
codex/issue-129-distribution
Oct 2, 2026
Merged

link1345 merged 9 commits into
mainfrom
codex/issue-129-distribution

Conversation

@link1345

@link1345 link1345 commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Godot release archives omitted gua_spatial.gd even though local spatial fixtures include it. Windows, Web and aggregate release assembly now share a verified source-staging function with Gua/godot-cpp notices. The asset packer extracts and validates the actual final ZIPs before assembling public assets.

For #129, adds pinned schema/resource APIs and offline structural validation to Gua.Testing, plus embedded Viewer source/hash/license metadata. External consumers restore outside the repository with isolated caches, use only package references and the retained local feed for acceptance, and reject native overrides. Four-RID CI exercises an extracted self-contained archive, native-free offline schema/Trace/Viewer paths and an installed .NET Tool, retaining dependency/hash/license manifests and native closure evidence. Explicit content target paths preserve notices/ across macOS filesystem aliases.

Incorporates merged #122 / PR160 at 9891637. External package consumers exercise game-input v2 import into independent timed-segment v1, file round trip with offsets/defaults and legacy-unknown provenance, rejected undeclared versions, and values-free result serialization through Trace. Managed UI Recording remains v1. Serialization fixtures never execute Replay or establish host application timing. Both new schemas are shipped unchanged with package-local reference closure.

Validation: final head 91fb854 passed all 17 jobs in https://github.com/gua-project/gua/actions/runs/36972320745, including all four external package consumers, native closure checks, embedded Viewer browser QA and Godot desktop/Web routes. Package metadata and artifacts pin the actual tested merge checkout 7e7589a. Focused managed net10.0/netstandard2.1 builds and diff checks also passed. Independent final cumulative review reported no remaining actionable findings after correcting the Recording v2 fixture and adding full schema validation before import; all 35 schema references close.

This PR advances #129 without closing its public-distribution gate: the owner must choose the final public version/channel and verify actual published artifacts and declared engine routes. Loading, launch, attachment and feature support remain separate evidence.

No release, publication, gua-v tag or deployment is performed by this PR.

@link1345
link1345 force-pushed the codex/issue-129-distribution branch from c68cbf0 to 74e4ad4 Compare October 2, 2026 06:06
@link1345
link1345 marked this pull request as ready for review October 2, 2026 06:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T06:44:20.289316Z 91fb854 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant