Repository navigation
Add distribution acceptance and complete Godot release archives - #163
Merged
Merged
Conversation
link1345
force-pushed
the
codex/issue-129-distribution
branch
from
October 2, 2026 06:06
c68cbf0 to
74e4ad4
Compare
link1345
marked this pull request as ready for review
October 2, 2026 06:41
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Godot release archives omitted gua_spatial.gd even though local spatial fixtures include it. Windows, Web and aggregate release assembly now share a verified source-staging function with Gua/godot-cpp notices. The asset packer extracts and validates the actual final ZIPs before assembling public assets.
For #129, adds pinned schema/resource APIs and offline structural validation to Gua.Testing, plus embedded Viewer source/hash/license metadata. External consumers restore outside the repository with isolated caches, use only package references and the retained local feed for acceptance, and reject native overrides. Four-RID CI exercises an extracted self-contained archive, native-free offline schema/Trace/Viewer paths and an installed .NET Tool, retaining dependency/hash/license manifests and native closure evidence. Explicit content target paths preserve notices/ across macOS filesystem aliases.
Incorporates merged #122 / PR160 at 9891637. External package consumers exercise game-input v2 import into independent timed-segment v1, file round trip with offsets/defaults and legacy-unknown provenance, rejected undeclared versions, and values-free result serialization through Trace. Managed UI Recording remains v1. Serialization fixtures never execute Replay or establish host application timing. Both new schemas are shipped unchanged with package-local reference closure.
Validation: final head 91fb854 passed all 17 jobs in https://github.com/gua-project/gua/actions/runs/36972320745, including all four external package consumers, native closure checks, embedded Viewer browser QA and Godot desktop/Web routes. Package metadata and artifacts pin the actual tested merge checkout 7e7589a. Focused managed net10.0/netstandard2.1 builds and diff checks also passed. Independent final cumulative review reported no remaining actionable findings after correcting the Recording v2 fixture and adding full schema validation before import; all 35 schema references close.
This PR advances #129 without closing its public-distribution gate: the owner must choose the final public version/channel and verify actual published artifacts and declared engine routes. Loading, launch, attachment and feature support remain separate evidence.
No release, publication, gua-v tag or deployment is performed by this PR.