Repository navigation
fix(76): fold F25 — pin the emitted-branch rule for both freeze-batch classes - #328
Merged
Merged
Conversation
… classes F14's route cell demanded both branches be pinned; only the freeze-batch table row was, so rewriting the emitted-branch paragraph in `skills/fold-findings/references/FOLD_PROCESS.md` (product-owner freeze selects `REPLAN-ROUTE` instead of `PRODUCT-ROUTE`) left `node --test scripts/review-loop-discipline.test.mjs` green. The new pin reads the pairing out of that paragraph and asserts both halves, so either swap fails. Swept surfaces: the F25 ledger row flips `folded: no → yes` in this commit. Gate: `node --test scripts/*.test.mjs` → exit 0, 929 pass / 0 fail; `node --test scripts/review-loop-discipline.test.mjs` → exit 0; red on the mutation (AssertionError: a frozen (product owner present) batch must select PRODUCT-ROUTE).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Folds the one still-reproducible fix-now row from unit 76's fold ledger: F25.
F14's
Routecell demanded both freeze-batch branches be pinned. The table row was pinned; the emitted-branch paragraph was not. Before this PR, editingskills/fold-findings/references/FOLD_PROCESS.md:55-58so afrozen (product owner present)batch selectsREPLAN-ROUTEleftnode --test scripts/review-loop-discipline.test.mjsgreen — the rule the loop actually emits was unprotected.Change
scripts/review-loop-discipline.test.mjs: new pin10e2/#293 F25reads the pairing out of the emitted-branch paragraph and asserts both halves (frozen (replan present)→REPLAN-ROUTE,frozen (product owner present)→PRODUCT-ROUTE).docs/features/76-lane-product-route/review-findings.md: F25 flippedfolded: no → yesin the fix commit;scripts/ledger-provenance.mjs --annotaterecorded the· foldmarker (CHECK PASS).No skill prose, schema, or package surface changed; no test weakened.
Gate (RUN, not assumed)
node --test scripts/review-loop-discipline.test.mjs→ exit 0PRODUCT-ROUTE→REPLAN-ROUTEin the pinned sentence →fail 1,AssertionError: a frozen (product owner present) batch must select PRODUCT-ROUTEnode scripts/ledger-provenance.mjs docs/features/76-lane-product-route/review-findings.md --check→CHECK PASS(proven-cited 23, open 3)node --test scripts/*.test.mjs→ exit 0 — 929 pass / 0 failRefs unit 76 (
docs/features/76-lane-product-route/), finding F25. No package version bump: the diff touches noskills/**orpackages/pi-agentic-workflow/**surface.Automated written using a AI