Added Node version switcher instead of nvm-ps to fix windows ci issue - #3085
Merged
Merged
Conversation
murgatroid99
approved these changes
Sep 15, 2026
murgatroid99
left a comment
murgatroid99
left a comment
Member
There was a problem hiding this comment.
This change seems to have solved the relevant problem. The job is still failing, but I believe it will be fixed by #3030.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows ci failures occured for grpc-node because the legacy nvm-ps installation command in run-tests.bat attemped to use PowerShell's Invoke-WebRequest without the
UseBasicParsingflag. Replaced nvm-ps with nvs(maintained node version switcher library) . nvm-windows was considered and avoided because of its architectural dependence on .exe installers since v2.0.0.