chore(grpc-js): unify call numbers and avoid disabled trace allocations - #3084
Merged
Merged
Conversation
Previously, each layer of an RPC (ResolvingCall, RetryingCall, LoadBalancingCall, and Http2SubchannelCall) allocated its own separate call number via getNextCallNumber(). This made correlating logs across layers difficult and consumed multiple IDs per logical RPC. Additionally, dynamic trace arguments such as string concatenations, JSON.stringify(), and deadline formatting were evaluated eagerly at call sites even when tracing was disabled, adding unnecessary garbage collection pressure on the fast path. This change: 1. Passes the initial callNumber from ResolvingCall down through RetryingCall, LoadBalancingCall, and Http2SubchannelCall so that all layers of an attempt share the same call number. Subsequent retries and hedged attempts allocate a new call number per attempt. 2. Short-circuits isTracerEnabled() when no tracers are active and guards dynamic trace argument evaluation behind traceEnabled checks so that disabled tracers incur zero string or formatting allocations.
murgatroid99
approved these changes
Sep 16, 2026
Member
|
This is out in version 1.14.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, each layer of an RPC (ResolvingCall, RetryingCall, LoadBalancingCall, and Http2SubchannelCall) allocated its own separate call number via getNextCallNumber(). This made correlating logs across layers difficult and consumed multiple IDs per logical RPC.
Additionally, dynamic trace arguments such as string concatenations, JSON.stringify(), and deadline formatting were evaluated eagerly at call sites even when tracing was disabled, adding unnecessary garbage collection pressure on the fast path.
This change: