Skip to content

servlet: add extra 5s to AsyncContext timeout - #12321

Merged
kannanjgithub merged 3 commits into
grpc:masterfrom
panchenko:servlet-ASYNC_TIMEOUT_SAFETY_MARGIN
Sep 16, 2025
Merged

kannanjgithub merged 3 commits into
grpc:masterfrom
panchenko:servlet-ASYNC_TIMEOUT_SAFETY_MARGIN

Conversation

@panchenko

Copy link
Copy Markdown
Contributor

Currently there is a race between 2 tasks scheduled to handle request timeout

  • servlet AsyncContext timeout
  • gRPC Context

which can cause instability

@panchenko
panchenko marked this pull request as ready for review August 28, 2025 15:16
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Aug 28, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Aug 28, 2025
@kannanjgithub
kannanjgithub merged commit d163c06 into grpc:master Sep 16, 2025
16 checks passed
AgraVator pushed a commit to AgraVator/grpc-java that referenced this pull request Sep 26, 2025
Currently there is a race between 2 tasks scheduled to handle request
timeout
* servlet AsyncContext timeout
* gRPC Context

which can cause instability. This change makes the gRPC Context timeout happen first.
AgraVator pushed a commit to AgraVator/grpc-java that referenced this pull request Sep 26, 2025
Currently there is a race between 2 tasks scheduled to handle request
timeout
* servlet AsyncContext timeout
* gRPC Context

which can cause instability. This change makes the gRPC Context timeout happen first.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants