Repository navigation
allow java21 in jre matrix - #12281
Merged
Merged
Conversation
shivaspeaks
marked this pull request as ready for review
August 18, 2025 13:19
ejona86
reviewed
Aug 19, 2025
ejona86
left a comment
ejona86
left a comment
Member
There was a problem hiding this comment.
If you silence a warning, it is forever lost. If we should be fixing a warning, we can silence it, but we should at least create a tracking issue for it so we can fix it. Adding transient for serializable problems is not a panacea. For most of those I'd much rather continue having broken serialization (e.g., by suppressing the warning) than acting as if serialization works when it is really broken.
ejona86
approved these changes
Aug 28, 2025
kannanjgithub
previously approved these changes
Aug 29, 2025
kannanjgithub
approved these changes
Aug 29, 2025
shivaspeaks
added a commit
to shivaspeaks/grpc-java
that referenced
this pull request
Sep 1, 2025
jdcormie
pushed a commit
to jdcormie/grpc-java
that referenced
this pull request
Sep 12, 2025
AgraVator
pushed a commit
to AgraVator/grpc-java
that referenced
this pull request
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.