Repository navigation
Build and test with Go 1.26.10 - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Go releases before 1.26.10 accept certificate chains signed through eight compromised eMudhra intermediate CAs (CVE-2026-111943 / GO-2026-6809). groupcache-go's HTTP transport verifies peers over TLS when a TLS config is set, so callers inherit the hole from the Go they build with. This moves the module and its CI to the fixed Go.
Importers now need Go 1.26.10 or later, which the user chose for this ticket, as for gubernator in ENG-578.
Implementation
go.mod:goline raised to 1.26.10.go mod tidyleavesgo.sumunchanged.1.24.xmatrix (one OS, one version) and setgo-version-file: go.mod, so CI tracks the module's minimum.Makefile(was v1.61.0, a v1 release; the repo has no lint config, so v2 defaults apply).transport/mock_transport.go: v2.15.0 reports staticcheck QF1012 onWriteString(fmt.Sprintf(...)), so it is nowfmt.Fprintf. Same output.Verification
Ran with
GOTOOLCHAIN=go1.26.10:go mod tidy(no diff beyondgo.mod),go vet ./...,golangci-lint run ./...(golangci-lint 2.11.4 locally, 0 issues after the fix; CI uses v2.15.0, not yet run),go test -count=1 ./...(all pass). One earlierTestTLSrun failed withaddress already in useon port 1111 and passed on rerun; nothing else held the port afterward.Not run: the GitHub Actions workflow, and a v2.15.0 lint run. Review was my own read of a four-file diff; no sub-agent lenses.
v3.5.1 is to be tagged after merge.
Fixes ENG-584