Add text domain to dashboard i18n calls - #72
Open
GreggFranklin wants to merge 3 commits into
Open
Conversation
Update dashboard JS (and minified build) to include the 'groundhogg' text domain on wp.i18n calls and related strings for proper translation context. Also add/update locale JSON translation files (de_DE, es_AR, es_ES, fr_FR, it_IT, pt_BR) to include the new/changed strings.
Wrap dashboard stat labels with __() in assets/js/admin/features/dashboard.js (and update the minified bundle). Register a new admin script handle 'groundhogg-admin-components' in includes/scripts.php. Add and update generated locale JSON files for multiple locales (de_DE, es_AR, es_ES, fr_FR, it_IT, pt_BR) containing translations for assets/js/admin/components.js and dashboard.js. These changes enable proper translations for dashboard UI strings and ensure the components script is enqueued for admin usage.
Add new dashboard UI scripts (assets/js/admin/features/dashboard 2.js and minified) which implement the dashboard widgets and related components. Update includes/scripts.php to include 'groundhogg-make-el' and 'groundhogg-admin-saved-replies' in the admin script list so the dashboard has its required dependencies available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dashboard JS (and minified build) to include the 'groundhogg' text domain on wp.i18n calls and related strings for proper translation context. Also add/update locale JSON translation files (de_DE, es_AR, es_ES, fr_FR, it_IT, pt_BR) to include the new/changed strings.