Repository navigation
feat(fdc3): Desktop Agent selection in Terminal + per-user agent config - #67
Open
griffithtp wants to merge 5 commits into
Open
griffithtp wants to merge 5 commits into
griffithtp wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fdc3section interminal.config.json, the Terminal injected an empty agent URL, whichfdc3-pluginreads as "FDC3 off". A missing key now falls back tows://localhost:7891/fdc3.""still turns FDC3 off. Error messages now name the config key to set.agent.config.jsonin the user's config dir (e.g.~/Library/Application Support/one-terminal/) layers between the bundled file andOT_*env vars. Partial files are allowed, unknown keys are warned about, and every setting is logged at startup with its source.fdc3.agents[]andfdc3.defaultAgent. Users switch from App Menu → Desktop Agent, the header badge, or the command palette.OT_FDC3_AGENT_URLoverrides it and makes the picker read-only.docs/fdc3.mdcovering how widgets connect, choosing an agent, connector kinds, and Desktop Agent config. Code comments and the README point to it.GetCurrentContext,FindIntent,FindIntentsForContext,GetRegisteredAppsand intent raising in the Desktop Agent andot-fdc3.No breaking config changes.
Test plan
cargo test(12 new tests), clippy,tsc, ESLint andvite buildare cleanHOME: each setting showed the right source, and a saved agent that was removed from config fell back to the default with a noticeOT_FDC3_AGENT_URLset, the picker is read-only